From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBPs9-0005o8-Jz for qemu-devel@nongnu.org; Tue, 22 Dec 2015 11:33:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBPs5-0002EC-JZ for qemu-devel@nongnu.org; Tue, 22 Dec 2015 11:33:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBPs5-0002E5-Dk for qemu-devel@nongnu.org; Tue, 22 Dec 2015 11:33:09 -0500 References: <1450799164-14027-1-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <56797B43.70801@redhat.com> Date: Tue, 22 Dec 2015 09:33:07 -0700 MIME-Version: 1.0 In-Reply-To: <1450799164-14027-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jSeHxHBfcxiFH9cXTCxlU4N71Oatxach7" Subject: Re: [Qemu-devel] [PATCH] io: bind to loopback IP addrs in test suite List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Peter Maydell This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jSeHxHBfcxiFH9cXTCxlU4N71Oatxach7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/22/2015 08:46 AM, Daniel P. Berrange wrote: > The test suite currently binds to 0.0.0.0 or ::, which covers > all interfaces of the machine. It is bad practice for test > suite to open publically accessible ports on a machine, so > switch to use loopback addrs 127.0.0.1 or ::1. >=20 > Reported-by: Peter Maydell > Signed-off-by: Daniel P. Berrange > --- > tests/test-io-channel-socket.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jSeHxHBfcxiFH9cXTCxlU4N71Oatxach7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWeXtDAAoJEKeha0olJ0NqGq0IAJQl35j0HRYrAKRrLXuJuVBv WnI/BbtrD5qmxx91bBfSWmP+HAnMsp9T9jbTGsfrsfRMeWonMTYG6Rl9HDLxUqSk 6Ur2oQ5djjVtd9by9QiSpJ0hjvNghsOFjWEt+wCPY1+NAUVsJ3QYc5PAjG0Vabfb uU6D3q7HjqVQcomGFvhkK1tWvPpW2/9R5Iupk1H7EuqJmkFE8oZ2jhTfUuxXunhA SwiIOL/a78KeIxq/0DDhXeMEVmxUzC6vqUdQvK4JzYrLFs4RFVHxnqphO9pJz7OD IYeLDA/ZGpVcE2wu+f7NPsRsJ+uVswPnERp/3c2ZNX8bYKKe0QrjfxIlwp7AHYo= =YoRB -----END PGP SIGNATURE----- --jSeHxHBfcxiFH9cXTCxlU4N71Oatxach7--