From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBUOI-0007Gu-VU for qemu-devel@nongnu.org; Tue, 22 Dec 2015 16:22:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBUOI-0004Tf-0t for qemu-devel@nongnu.org; Tue, 22 Dec 2015 16:22:42 -0500 References: <1450802786-20893-1-git-send-email-kwolf@redhat.com> <1450802786-20893-9-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5679BF1A.2050109@redhat.com> Date: Tue, 22 Dec 2015 14:22:34 -0700 MIME-Version: 1.0 In-Reply-To: <1450802786-20893-9-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V83VVgx7iQJt6vFub63x3jLf78ScICmun" Subject: Re: [Qemu-devel] [PATCH 08/10] qcow2: Fix BDRV_O_INCOMING handling in qcow2_invalidate_cache() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V83VVgx7iQJt6vFub63x3jLf78ScICmun Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/22/2015 09:46 AM, Kevin Wolf wrote: > What qcow2_invalidate_cache() should do is closing the image with > BDRV_O_INCOMING set and reopening it with the flag cleared. In fact, it= Might read better with s/closing/close/, s/reopening/reopen/ > used to do exactly the opposite: qcow2_close() relied on bs->open_flags= , > which is already updated to have cleared BDRV_O_INCOMING at this point,= > whereas qcow2_open() was called with s->flags, which has the flag still= > set. Fix this. >=20 > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --V83VVgx7iQJt6vFub63x3jLf78ScICmun Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWeb8aAAoJEKeha0olJ0NqQTcH/2wjmtQkC18j2Mw6j1gR2F9w nTaDLZygQZVuGZT+Vg5jS6zf0fkI5tvk6SkfEqEXp8YKMXvDOLkihomaumjLxkj4 nUjoh2OlJW0M6K45MlyHZgahtQTRYU75/7y7tEij4MY5Z0x4Mjd81SISvMXGO5WP egOxd+PVyEvYFwdzWmShbC2hFLrvz2EEfFq6Nn/slbIl2RMWTPFFfoonTG2JCHih 2akvQr7uAT1TQ6dvnzMLpH/m/Q65ctKWiSgijiZc0AZBlHQakPBGQP1QFwxYU0As TCP3KrIPWJpu1F5+l3v4BsZ8MmxD4lrkcbRANeE5Imofv3TvAizsxB69eRWWdaU= =ghku -----END PGP SIGNATURE----- --V83VVgx7iQJt6vFub63x3jLf78ScICmun--