From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Tadeusz Struk <tstruk@gmail.com>,
kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, linux-kernel@vger.kernel.org,
dhowells@redhat.com, linux-security-module@vger.kernel.org,
linux-crypto@vger.kernel.org, zohar@linux.vnet.ibm.com
Subject: Re: [PATCH v2 1/2] crypto: KEYS: convert public key to the akcipher api
Date: Tue, 22 Dec 2015 20:57:57 -0800 [thread overview]
Message-ID: <567A29D5.8090503@intel.com> (raw)
In-Reply-To: <20151223023343.GA31104@gondor.apana.org.au>
On 12/22/2015 06:33 PM, Herbert Xu wrote:
>> What about the first two. This one is completely unrelated.
>> > It only supposed to fix some random configuration issue
>> > reported by a build robot, which isn't really important now.
>> > The other two convert the module verifier to the new API.
> No this compile breakage was introduced by your first two patches
> because you changed crypto/public_key.h which is used by entities
> outside of your patch.
>
> So fix your first two patches by not breaking existing users
> of it.
Ok I can see the problem now. I just don't should not include
the asymmetric-type.h in the public_key.h and it fixes it.
Will send v3 soon.
Thanks,
--
TS
next prev parent reply other threads:[~2015-12-23 4:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 2:26 [PATCH v2 0/2] crypto: KEYS: convert public key to akcipher api Tadeusz Struk
2015-12-13 2:26 ` [PATCH v2 1/2] crypto: KEYS: convert public key to the " Tadeusz Struk
2015-12-19 23:49 ` kbuild test robot
2015-12-20 16:53 ` Tadeusz Struk
2015-12-21 20:59 ` Tadeusz Struk
2015-12-22 12:09 ` Herbert Xu
2015-12-22 14:23 ` Tadeusz Struk
2015-12-23 2:33 ` Herbert Xu
2015-12-23 4:57 ` Tadeusz Struk [this message]
2015-12-13 2:26 ` [PATCH v2 2/2] integrity: convert digsig to " Tadeusz Struk
2015-12-14 13:24 ` Mimi Zohar
2015-12-14 14:59 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567A29D5.8090503@intel.com \
--to=tadeusz.struk@intel.com \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tstruk@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.