From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply Date: Wed, 23 Dec 2015 14:00:34 +0800 Message-ID: <567A3882.3020808@rock-chips.com> References: <1450236018-1118-1-git-send-email-ykk@rock-chips.com> <1450238257-3274-1-git-send-email-ykk@rock-chips.com> <000a01d13cb4$0f81f510$2e85df30$@com> <567A21EC.4010003@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <567A21EC.4010003@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jingoo Han , 'Inki Dae' , 'Mark Yao' , 'Heiko Stuebner' Cc: devicetree@vger.kernel.org, 'Krzysztof Kozlowski' , linux-samsung-soc@vger.kernel.org, 'Russell King' , javier@osg.samsung.com, emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, 'Kishon Vijay Abraham I' , linux-rockchip@lists.infradead.org, 'Rob Herring' , 'Andy Yan' , 'Thierry Reding' , 'Gustavo Padovan' , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgSmluZ29vLAoKT24gMTIvMjMvMjAxNSAxMjoyNCBQTSwgWWFraXIgWWFuZyB3cm90ZToKPiBI aSBKaW5nb28sCj4KPiBPbiAxMi8yMi8yMDE1IDA4OjI2IFBNLCBKaW5nb28gSGFuIHdyb3RlOgo+ PiBPbiBXZWRuZXNkYXksIERlY2VtYmVyIDE2LCAyMDE1IDEyOjU4IFBNLCBZYWtpciBZYW5nIHdy b3RlOgo+Pj4gQWZ0ZXIgdGVzdCBvbiByb2NrY2hpb3AgcGxhdGZvcm0sIGkgZm91bmQgc29tZXRp bXMgZHJpdmVyIHdvdWxkIGZhaWxlZAo+Pj4gYXQgcmVhZGluZyBFRElEIG1lc3NhZ2UuIEFmdGVy IGRlYnVnZ2luZyBtb3JlLCBpIGZvdW5kIHRoYXQgaXQncyBva2F5Cj4+PiB0byByZWFkX2EgYnl0 ZSBmcm9tIGkyYywgYnV0IGl0IHdvdWxkIGZhaWxlZCBhdCBBVVggdHJhbnNjYXRpb24gaWYgd2UK Pj4+IHRyeSB0byByZWFkeSBtdWx0aS1ieXRlcyBmcm9tIGkyYy4KPj4+Cj4+PiBEcml2ZXIganVz dCBjYW4ndCByZWNlaXZlZCB0aGUgQVVYIENIIHJlcGx5IGNvbW1hbmQsIGV2ZW4gbm8gQVVYIGVy cm9yCj4+PiBjb2RlLiBJIG1heSBndWVzcyB0aGF0IHRoZSBBVVggd2FpdCB0aW1lIGlzIG5vdCBl bm91Z2gsIHNvIEkgdHJ5IHRvCj4+PiBleHBhbmQgdGhlIEFVWCB3YWl0IHRpbWUsIGFuZCBpIGRv IHNlZSB0aGlzIGNvdWxkIGZpeCB0aGUgRURJRCByZWFkCj4+PiBmYWlsZWQgYXQgcm9ja2NoaXAg cGxhdGZvcm0uCj4+Pgo+Pj4gQW5kIEkgdGhvdWdodCB0aGF0IGV4cGFuZCB0aGUgd2FpdCB0aW1l IHdvbid0IGh1cnQgRXh5bm9zIHBsYXRmb3JtIHRvbwo+Pj4gbXVjaCwgY2F1c2UgRXh5bm9zIGRp ZG4ndCBoYXZlIHRoaXMgcHJvYmxlbSwgdGhlbiBkcml2ZXIgd291bGQgcmVjZWl2ZWQKPj4+IHRo ZSByZXBseSBjb21tYW5kIHZlcnkgc29vbiwgc28gbm8gbW9yZSBhZGRpdGlvbmFsIHdhaXQgdGlt ZSB3b3VsZCAKPj4+IGJyaW5nCj4+PiB0byBFeHlub3MgcGxhdGZvcm0uCj4+Pgo+Pj4gU2lnbmVk LW9mZi1ieTogWWFraXIgWWFuZyA8eWtrQHJvY2stY2hpcHMuY29tPgo+Pj4gLS0tCj4+PiBDaGFu Z2VzIGluIHYxMTogTm9uZQo+Pj4gQ2hhbmdlcyBpbiB2MTA6IE5vbmUKPj4+IENoYW5nZXMgaW4g djk6IE5vbmUKPj4+IENoYW5nZXMgaW4gdjg6IE5vbmUKPj4+IENoYW5nZXMgaW4gdjc6IE5vbmUK Pj4+IENoYW5nZXMgaW4gdjY6IE5vbmUKPj4+IENoYW5nZXMgaW4gdjU6IE5vbmUKPj4+IENoYW5n ZXMgaW4gdjQ6IE5vbmUKPj4+IENoYW5nZXMgaW4gdjM6IE5vbmUKPj4+IENoYW5nZXMgaW4gdjI6 IE5vbmUKPj4+Cj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhf ZHBfcmVnLmMgfCAyICstCj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBk ZWxldGlvbigtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fu YWxvZ2l4L2FuYWxvZ2l4X2RwX3JlZy5jCj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5h bG9naXgvYW5hbG9naXhfZHBfcmVnLmMKPj4+IGluZGV4IGM3ZTI5NTkuLmRjMzc2YmQgMTAwNjQ0 Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX3Jl Zy5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2Rw X3JlZy5jCj4+PiBAQCAtNDgyLDcgKzQ4Miw3IEBAIGludCBhbmFsb2dpeF9kcF9zdGFydF9hdXhf dHJhbnNhY3Rpb24oc3RydWN0IAo+Pj4gYW5hbG9naXhfZHBfZGV2aWNlICpkcCkKPj4+ICAgICAg IHJlZyA9IHJlYWRsKGRwLT5yZWdfYmFzZSArIEFOQUxPR0lYX0RQX0lOVF9TVEEpOwo+Pj4gICAg ICAgd2hpbGUgKCEocmVnICYgUlBMWV9SRUNFSVYpKSB7Cj4+PiAgICAgICAgICAgdGltZW91dF9s b29wKys7Cj4+PiAtICAgICAgICBpZiAoRFBfVElNRU9VVF9MT09QX0NPVU5UIDwgdGltZW91dF9s b29wKSB7Cj4+PiArICAgICAgICBpZiAoRFBfVElNRU9VVF9MT09QX0NPVU5UICogMTAgPCB0aW1l b3V0X2xvb3ApIHsKPj4gTm8sIEkgaGF0ZSB0aGlzIGNvZGluZy4KPj4gYW5hbG9naXhfZHBfcmVn LmMgaXMgdGhlIGNvbW1vbiBjb2RlIHRoYXQgY2FuIGJlIHNoYXJlZCBieSB2YXJpb3VzIFNvQ3Mu Cj4+IFBsZWFzZSwgZmluZCBhbm90aGVyIHdheS4KPgo+IE9rYXksIEkgaGF2ZSBkb3VibGUgY2hl Y2tlZCB0aGF0IGkgZG8gaGF2ZSB0aGlzIHByb2JsZW0gaW4gbXkgc2lkZS4gCj4gSG1tbS4uLi4u Cj4gSSB0aG91Z2h0IGl0J3Mgb2theSBmb3IgeW91IGlmIEkgZXhwYW5kIHRoZSAiRFBfVElNRU9V VF9MT09QX0NPVU5UIiAKPiBkaXJlY3RseSwKPiBpdCB3b24ndCBodXJ0IEV4eW5vcyBwbGF0Zm9y bSB0b28gbXVjaCwgY2F1c2UgRXh5bm9zIGRpZG4ndCBoYXZlIHRoaXMgCj4gcHJvYmxlbSwKPiB0 aGVuIGRyaXZlciB3b3VsZCByZWNlaXZlZCx0aGUgcmVwbHkgY29tbWFuZCB2ZXJ5IHNvb24sIHNv IG5vIG1vcmUgCj4gYWRkaXRpb25hbAo+IHdhaXQgdGltZSB3b3VsZCBicmluZyB0byBFeHlub3Mg cGxhdGZvcm0uCj4KCk9oLCBzb3JyeSwgbGl0dGxlIG1pc3Rha2VuLCBJIG1lYW4sIGlzIGl0IG9r YXkgZm9yIHlvdSB0byBleHBhbmQgdGhlIAoiRFBfVElNRU9VVF9MT09QX0NPVU5UIiBkaXJlY3Rs eSA/CgotIFlha2lyCgoKPiBBbmQgYWN0dWFsbHkgdGhlIGRhdGFzaGVldCBoYXZlbid0IGRlc2Ny aWJlZCB0aGUgc3BlYyBvZiBhdXggcmVwbHkgCj4gZGVsYXkgdGltZS4KPgo+IFRoYW5rcywKPiAt IFlha2lyCj4KPj4gQmVzdCByZWdhcmRzLAo+PiBKaW5nb28gSGFuCj4+Cj4+Cj4+PiAgICAgICAg ICAgICAgIGRldl9lcnIoZHAtPmRldiwgIkFVWCBDSCBjb21tYW5kIHJlcGx5IGZhaWxlZCFcbiIp Owo+Pj4gICAgICAgICAgICAgICByZXR1cm4gLUVUSU1FRE9VVDsKPj4+ICAgICAgICAgICB9Cj4+ PiAtLSAKPj4+IDEuOS4xCj4+Cj4+Cj4+Cj4+Cj4KPgo+Cj4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiBMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QK PiBMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo+Cj4KPgoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Wed, 23 Dec 2015 14:00:34 +0800 Subject: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply In-Reply-To: <567A21EC.4010003@rock-chips.com> References: <1450236018-1118-1-git-send-email-ykk@rock-chips.com> <1450238257-3274-1-git-send-email-ykk@rock-chips.com> <000a01d13cb4$0f81f510$2e85df30$@com> <567A21EC.4010003@rock-chips.com> Message-ID: <567A3882.3020808@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Jingoo, On 12/23/2015 12:24 PM, Yakir Yang wrote: > Hi Jingoo, > > On 12/22/2015 08:26 PM, Jingoo Han wrote: >> On Wednesday, December 16, 2015 12:58 PM, Yakir Yang wrote: >>> After test on rockchiop platform, i found sometims driver would failed >>> at reading EDID message. After debugging more, i found that it's okay >>> to read_a byte from i2c, but it would failed at AUX transcation if we >>> try to ready multi-bytes from i2c. >>> >>> Driver just can't received the AUX CH reply command, even no AUX error >>> code. I may guess that the AUX wait time is not enough, so I try to >>> expand the AUX wait time, and i do see this could fix the EDID read >>> failed at rockchip platform. >>> >>> And I thought that expand the wait time won't hurt Exynos platform too >>> much, cause Exynos didn't have this problem, then driver would received >>> the reply command very soon, so no more additional wait time would >>> bring >>> to Exynos platform. >>> >>> Signed-off-by: Yakir Yang >>> --- >>> Changes in v11: None >>> Changes in v10: None >>> Changes in v9: None >>> Changes in v8: None >>> Changes in v7: None >>> Changes in v6: None >>> Changes in v5: None >>> Changes in v4: None >>> Changes in v3: None >>> Changes in v2: None >>> >>> drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >>> b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >>> index c7e2959..dc376bd 100644 >>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >>> @@ -482,7 +482,7 @@ int analogix_dp_start_aux_transaction(struct >>> analogix_dp_device *dp) >>> reg = readl(dp->reg_base + ANALOGIX_DP_INT_STA); >>> while (!(reg & RPLY_RECEIV)) { >>> timeout_loop++; >>> - if (DP_TIMEOUT_LOOP_COUNT < timeout_loop) { >>> + if (DP_TIMEOUT_LOOP_COUNT * 10 < timeout_loop) { >> No, I hate this coding. >> analogix_dp_reg.c is the common code that can be shared by various SoCs. >> Please, find another way. > > Okay, I have double checked that i do have this problem in my side. > Hmmm..... > I thought it's okay for you if I expand the "DP_TIMEOUT_LOOP_COUNT" > directly, > it won't hurt Exynos platform too much, cause Exynos didn't have this > problem, > then driver would received,the reply command very soon, so no more > additional > wait time would bring to Exynos platform. > Oh, sorry, little mistaken, I mean, is it okay for you to expand the "DP_TIMEOUT_LOOP_COUNT" directly ? - Yakir > And actually the datasheet haven't described the spec of aux reply > delay time. > > Thanks, > - Yakir > >> Best regards, >> Jingoo Han >> >> >>> dev_err(dp->dev, "AUX CH command reply failed!\n"); >>> return -ETIMEDOUT; >>> } >>> -- >>> 1.9.1 >> >> >> >> > > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754300AbbLWGAx (ORCPT ); Wed, 23 Dec 2015 01:00:53 -0500 Received: from lucky1.263xmail.com ([211.157.147.130]:38221 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbbLWGAv (ORCPT ); Wed, 23 Dec 2015 01:00:51 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply To: Jingoo Han , "'Inki Dae'" , "'Mark Yao'" , "'Heiko Stuebner'" References: <1450236018-1118-1-git-send-email-ykk@rock-chips.com> <1450238257-3274-1-git-send-email-ykk@rock-chips.com> <000a01d13cb4$0f81f510$2e85df30$@com> <567A21EC.4010003@rock-chips.com> Cc: devicetree@vger.kernel.org, "'Krzysztof Kozlowski'" , linux-samsung-soc@vger.kernel.org, "'Russell King'" , linux-rockchip@lists.infradead.org, emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "'Kishon Vijay Abraham I'" , javier@osg.samsung.com, "'Rob Herring'" , "'Andy Yan'" , "'Thierry Reding'" , "'Gustavo Padovan'" , linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <567A3882.3020808@rock-chips.com> Date: Wed, 23 Dec 2015 14:00:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <567A21EC.4010003@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jingoo, On 12/23/2015 12:24 PM, Yakir Yang wrote: > Hi Jingoo, > > On 12/22/2015 08:26 PM, Jingoo Han wrote: >> On Wednesday, December 16, 2015 12:58 PM, Yakir Yang wrote: >>> After test on rockchiop platform, i found sometims driver would failed >>> at reading EDID message. After debugging more, i found that it's okay >>> to read_a byte from i2c, but it would failed at AUX transcation if we >>> try to ready multi-bytes from i2c. >>> >>> Driver just can't received the AUX CH reply command, even no AUX error >>> code. I may guess that the AUX wait time is not enough, so I try to >>> expand the AUX wait time, and i do see this could fix the EDID read >>> failed at rockchip platform. >>> >>> And I thought that expand the wait time won't hurt Exynos platform too >>> much, cause Exynos didn't have this problem, then driver would received >>> the reply command very soon, so no more additional wait time would >>> bring >>> to Exynos platform. >>> >>> Signed-off-by: Yakir Yang >>> --- >>> Changes in v11: None >>> Changes in v10: None >>> Changes in v9: None >>> Changes in v8: None >>> Changes in v7: None >>> Changes in v6: None >>> Changes in v5: None >>> Changes in v4: None >>> Changes in v3: None >>> Changes in v2: None >>> >>> drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >>> b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >>> index c7e2959..dc376bd 100644 >>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >>> @@ -482,7 +482,7 @@ int analogix_dp_start_aux_transaction(struct >>> analogix_dp_device *dp) >>> reg = readl(dp->reg_base + ANALOGIX_DP_INT_STA); >>> while (!(reg & RPLY_RECEIV)) { >>> timeout_loop++; >>> - if (DP_TIMEOUT_LOOP_COUNT < timeout_loop) { >>> + if (DP_TIMEOUT_LOOP_COUNT * 10 < timeout_loop) { >> No, I hate this coding. >> analogix_dp_reg.c is the common code that can be shared by various SoCs. >> Please, find another way. > > Okay, I have double checked that i do have this problem in my side. > Hmmm..... > I thought it's okay for you if I expand the "DP_TIMEOUT_LOOP_COUNT" > directly, > it won't hurt Exynos platform too much, cause Exynos didn't have this > problem, > then driver would received,the reply command very soon, so no more > additional > wait time would bring to Exynos platform. > Oh, sorry, little mistaken, I mean, is it okay for you to expand the "DP_TIMEOUT_LOOP_COUNT" directly ? - Yakir > And actually the datasheet haven't described the spec of aux reply > delay time. > > Thanks, > - Yakir > >> Best regards, >> Jingoo Han >> >> >>> dev_err(dp->dev, "AUX CH command reply failed!\n"); >>> return -ETIMEDOUT; >>> } >>> -- >>> 1.9.1 >> >> >> >> > > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > >