From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] cmd_boot: Add a poweroff command
Date: Wed, 23 Dec 2015 11:52:40 +0100 [thread overview]
Message-ID: <567A7CF8.4070809@redhat.com> (raw)
In-Reply-To: <20151223063355.7F2A1383C1F@gemini.denx.de>
Hi,
On 23-12-15 07:33, Wolfgang Denk wrote:
> Dear Hans de Goede,
>
> In message <1450822985-19135-1-git-send-email-hdegoede@redhat.com> you wrote:
>> From: Michael van Slingerland <michael@deviousops.nl>
>>
>> Add a 'poweroff' command to boot commands, this only gets enabled if the
>> board Kconfig does a "select CMD_POWEROFF".
>
> Do you plan to submit any code that will actually implement and use
> this feature?
>
> As is, this is just dead code, and anybody who enables the option just
> runs into build errors.
>
> As is:
>
> NAK.
<sigh> as you may have noticed this is a v2 of this patch, v1 was part of a
set which did actually implement support for this and came with a coverletter
explaining why this is a desirable feature.
Regards,
Hans
prev parent reply other threads:[~2015-12-23 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 22:23 [U-Boot] [PATCH v2] cmd_boot: Add a poweroff command Hans de Goede
2015-12-23 6:33 ` Wolfgang Denk
2015-12-23 10:52 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567A7CF8.4070809@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.