Re: [PATCH for-next v1 0/2] Advertise atomic operations support in mlx5

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]

On 12/14/2015 09:34 AM, Eran Ben Elisha wrote:
> Hi Doug,
> 
> This patch set adds the functionality to advertise standard atomic operations
> capabilities for mlx5 driver.  The Hardware can be configured to work in two
> modes according to the device capabilities: 1. Big Endian requestor respond 2.
> Host Endian requestor respond
> 
> If the firmware supports host endianness, try to configure the hardware to work
> this way, and on success propagate this capability to the upper layers,
> otherwise advertise that atomic operations aren't supported.

If you are not going to allow any support except for host endian, then
why bother with all of the BE stuff, can't you just list it as supported
or not?

> Thanks, Eran
> 
> Changes from v0:
> 	- Rewrite the commit message of the second patch in the series
> 
> 
> Eran Ben Elisha (2):
>   net/mlx5_core: Configure HW to support atomic request in host
>     endianness

I can fix this up, but generally try to keep your subject of patches
short enough to fit in the generally accepted length.

>   IB/mlx5: Advertise atomic capabilities in query device
> 
>  drivers/infiniband/hw/mlx5/main.c              | 28 ++++++++++++-
>  drivers/net/ethernet/mellanox/mlx5/core/main.c | 57 +++++++++++++++++++++++++-
>  include/linux/mlx5/driver.h                    |  5 +++
>  include/linux/mlx5/mlx5_ifc.h                  | 22 ++++++----
>  4 files changed, 102 insertions(+), 10 deletions(-)
> 


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]