Re: [PATCH 0/3] IB core: 64 bit counter support V3

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2053 bytes --]

On 12/21/2015 09:20 AM, Christoph Lameter wrote:
> V2->V3
>   - Also add support for NOIETF counter mode where we have 64 bit
>   	counters but not the multicast/unicast counters.
>   - Add Reviewed-by's from Hal.
> 
> V1->V2
>   - Add detection of the capability for 64 bit counter support
>   - Lots of improvements as a result of suggestions by Hal Rosenstock.
> 
> Currently we only use 32 bits for the packet and byte counters. There have
> been extended countes available for some time but we have no support for
> those yet upstream. We keep having issues with 32 bit counters wrapping.
> Especially the byte counter can wrap frequently (as in multiple times per
> minute)
> 
> This patch adds 4 new counters (for full extended mode) and updates 4 32
> bit counters to use the 64 bit sizes (for NOIETF and full extended mode)
> so that they no longer wrap.
> 
> Should the device not support 64 bit counters then only the original 32
> bit counters will be visible.
> 
> This patchset can be pulled from my git repo on kernel.org
> 
> git pull git://git.kernel.org/pub/scm/linux/kernle/git/christoph/rdma.git counter_64bit
> 
> Thanks to Hal Rosenstock and Ira Weiny for reviewing this patchset.
> 

Hi Christoph,

I've pulled this set in.  However, two things would be helpful in the
future:

1) Prepend the area you are patching to your patch subjects.  Aka, you
put IB core: on the cover letter, but the individual patches did not
have that.  They should (and generally I would use IB/core:).

2) When assigning a V1/V2/V3, pass that as part of the --subject-prefix
you give to git.  When you use it on the cover letter, patchworks drops
it entirely (patchworks does not keep cover letters, and does not
transfer v1 tags from cover letters to the subsequent patches).  This
makes it *much* easier for me to pick out which of your patches in
patchworks are the most recent.

Thanks ;-)

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]