From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Wengang Wang
<wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Matt-goXnUAHYgFxWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH] IB/mlx4: Replace kfree with kvfree in mlx4_ib_destroy_srq
Date: Wed, 23 Dec 2015 14:35:46 -0500 [thread overview]
Message-ID: <567AF792.5050207@redhat.com> (raw)
In-Reply-To: <1450320855-4570-1-git-send-email-wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
On 12/16/2015 09:54 PM, Wengang Wang wrote:
> Commit 0ef2f05c7e02ff99c0b5b583d7dee2cd12b053f2 uses vmalloc for WR buffers
> when needed and uses kvfree to free the buffers. It missed changing kfree
> to kvfree in mlx4_ib_destroy_srq().
>
> Reported-by: Matthew Finaly <matt-goXnUAHYgFxWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Wengang Wang <wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/infiniband/hw/mlx4/srq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/mlx4/srq.c b/drivers/infiniband/hw/mlx4/srq.c
> index 8d133c4..c394376 100644
> --- a/drivers/infiniband/hw/mlx4/srq.c
> +++ b/drivers/infiniband/hw/mlx4/srq.c
> @@ -286,7 +286,7 @@ int mlx4_ib_destroy_srq(struct ib_srq *srq)
> mlx4_ib_db_unmap_user(to_mucontext(srq->uobject->context), &msrq->db);
> ib_umem_release(msrq->umem);
> } else {
> - kfree(msrq->wrid);
> + kvfree(msrq->wrid);
> mlx4_buf_free(dev->dev, msrq->msrq.max << msrq->msrq.wqe_shift,
> &msrq->buf);
> mlx4_db_free(dev->dev, &msrq->db);
>
Thanks, applied.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
prev parent reply other threads:[~2015-12-23 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 2:54 [PATCH] IB/mlx4: Replace kfree with kvfree in mlx4_ib_destroy_srq Wengang Wang
[not found] ` <1450320855-4570-1-git-send-email-wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-12-23 19:35 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567AF792.5050207@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=Matt-goXnUAHYgFxWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.