From: Max Reitz <mreitz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: make check-block.sh work on out-of-tree builds
Date: Wed, 23 Dec 2015 23:02:57 +0100 [thread overview]
Message-ID: <567B1A11.4080408@redhat.com> (raw)
In-Reply-To: <1450867341-11100-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On 23.12.2015 11:42, Paolo Bonzini wrote:
> Since check-block.sh, the "check" script has learnt to find the source
> path. On the other hand, it expects common.env to be in the build tree
> (both changes made in commit 76c7560, "configure: Enable out-of-tree
> iotests", 2014-05-24). So, it is wrong to invoke "check" from the source
> path like check-block.sh does. Fix it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/check-block.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Assuming that this scripts belongs to the iotests which are maintained
by Kevin (and subsequently me) (it isn't covered by MAINTAINERS):
Thanks, applied to my block tree:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-12-23 22:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 10:42 [Qemu-devel] [PATCH] qemu-iotests: make check-block.sh work on out-of-tree builds Paolo Bonzini
2015-12-23 22:02 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567B1A11.4080408@redhat.com \
--to=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.