Re: [Qemu-devel] [PATCH] block/qapi: Clear err for further error

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

On 22.12.2015 15:39, John Snow wrote:
> 
> 
> On 12/22/2015 05:11 AM, Fam Zheng wrote:
>> Since a5002d5 (block/qapi: allow best-effort query) we don't return at
>> this error, however err must be cleared before passing to
>> bdrv_query_snapshot_info_list below, as required by error API.
>>
>> Signed-off-by: Fam Zheng <famz@redhat.com>
>> ---
>>  block/qapi.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/block/qapi.c b/block/qapi.c
>> index fecac25..58d3975 100644
>> --- a/block/qapi.c
>> +++ b/block/qapi.c
>> @@ -250,6 +250,7 @@ void bdrv_query_image_info(BlockDriverState *bs,
>>              g_free(backing_filename2);
>>              backing_filename2 = NULL;
>>              error_free(err);
>> +            err = NULL;
>>          }
>>  
>>          /* Always report the full_backing_filename if present, even if it's the
>>
> 
> Sorry Markus, I've failed you.
> 
> Reviewed-by: John Snow <jsnow@redhat.com>

As did I by giving an R-b and applying it.

Let us hereby atone for our sins:

https://github.com/XanClic/qemu/commits/block


I hope the spirit of christmas will make Markus forgive us.

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]