From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aC2bK-0003Ai-AZ for qemu-devel@nongnu.org; Thu, 24 Dec 2015 04:54:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aC2bG-0002z8-Ei for qemu-devel@nongnu.org; Thu, 24 Dec 2015 04:54:26 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:60210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aC2bG-0002yw-4r for qemu-devel@nongnu.org; Thu, 24 Dec 2015 04:54:22 -0500 References: <1450919253-3237-1-git-send-email-chengang@emindsoft.com.cn> From: Laurent Vivier Message-ID: <567BC0C1.80907@vivier.eu> Date: Thu, 24 Dec 2015 10:54:09 +0100 MIME-Version: 1.0 In-Reply-To: <1450919253-3237-1-git-send-email-chengang@emindsoft.com.cn> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] linux-user/mmap.c: Use end instead of real_end in target_mmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: riku.voipio@iki.fi, Chen Gang Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, rth@twiddle.net Le 24/12/2015 02:07, chengang@emindsoft.com.cn a écrit : > From: Chen Gang > > In this case, real_end is larger than end, which may cause mmap_frag > process the incorrect memory region. > > Signed-off-by: Chen Gang > --- > linux-user/mmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/mmap.c b/linux-user/mmap.c > index 7b459d5..57b0361 100644 > --- a/linux-user/mmap.c > +++ b/linux-user/mmap.c > @@ -536,7 +536,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int prot, > /* handle the end of the mapping */ > if (end < real_end) { > ret = mmap_frag(real_end - qemu_host_page_size, > - real_end - qemu_host_page_size, real_end, > + real_end - qemu_host_page_size, end, > prot, flags, fd, > offset + real_end - qemu_host_page_size - start); > if (ret == -1) > The fragment must effectively be mapped only to "end" not to "real_end" (which is a host page aligned address, and thus this is not a fragment). It is consistent with what it is done in the case of one single page. Reviewed-by: Laurent Vivier