All of lore.kernel.org
 help / color / mirror / Atom feed
From: sagig@dev.mellanox.co.il (Sagi Grimberg)
Subject: [PATCH 3/3] nvme: make SG_IO support optional
Date: Thu, 24 Dec 2015 13:31:32 +0200	[thread overview]
Message-ID: <567BD794.2020607@dev.mellanox.co.il> (raw)
In-Reply-To: <20151224111248.GB15268@lst.de>


>>> Translation SCSI commands to NVMe commands is rather pointless in general
>>> as applications must not expext to be able to use SCSI commands on a
>>> generic block device.
>>>
>>> Make the huge translation layer optional and hope no one will ever enable
>>> it in the future.
>>
>> Umm, this is needed to support multipathing (at least in the multipath
>> daemon current form). I'm not sure this is a good idea just yet...
>
> It's not required, it's just you being lazy.

I didn't say it's required, I said it's needed for the current
multipathd implementation... and yes, I am lazy, multipathd is
not the most friendly code...

> I defintivively want
> to avoid people relying on this before actual multi path hardware
> ships.  So feel free to enable it while you're lazy for now, but
> I want people to disable it normally.

OK, I see what you mean. We can look at having multipathd ioctl'ing
identify_ns at some point...

  reply	other threads:[~2015-12-24 11:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-24 10:15 namespace list locking and ioctl fixes Christoph Hellwig
2015-12-24 10:15 ` [PATCH 1/3] nvme: synchronize access to ctrl->namespaces Christoph Hellwig
2015-12-24 10:36   ` Sagi Grimberg
2015-12-24 11:08     ` Christoph Hellwig
2015-12-24 10:15 ` [PATCH 2/3] nvme: fixes for NVME_IOCTL_IO_CMD on the char device Christoph Hellwig
2015-12-24 10:37   ` Sagi Grimberg
2015-12-24 10:15 ` [PATCH 3/3] nvme: make SG_IO support optional Christoph Hellwig
2015-12-24 10:39   ` Sagi Grimberg
2015-12-24 11:12     ` Christoph Hellwig
2015-12-24 11:31       ` Sagi Grimberg [this message]
2015-12-24 11:40         ` Christoph Hellwig
2015-12-24 15:29           ` Keith Busch
2015-12-24 15:45             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567BD794.2020607@dev.mellanox.co.il \
    --to=sagig@dev.mellanox.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.