All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2] ixgbe: on recv increment rx.ring->stats.yields
Date: Fri, 25 Dec 2015 19:26:12 +0300	[thread overview]
Message-ID: <567D6E24.3030302@virtuozzo.com> (raw)
In-Reply-To: <1449842714-10284-1-git-send-email-ptikhomirov@virtuozzo.com>

Hi, please, let me know if I need to fix something else here.

On 12/11/2015 05:05 PM, Pavel Tikhomirov wrote:
> It seem to be non intentionaly changed to tx in
> commit adc810900a70 ("ixgbe: Refactor busy poll socket code to address
> multiple issues")
>
> Lock is taken from ixgbe_low_latency_recv, and there under this
> lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
> tx counter.
>
> Yield stats can be shown through ethtool:
> ethtool -S enp129s0 | grep yield
>
> v2: follow commit citing style
>
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
> ---
>   drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> index 1d21745..7656d46 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> @@ -451,7 +451,7 @@ static inline bool ixgbe_qv_lock_poll(struct ixgbe_q_vector *q_vector)
>   				IXGBE_QV_STATE_POLL);
>   #ifdef BP_EXTENDED_STATS
>   	if (rc != IXGBE_QV_STATE_IDLE)
> -		q_vector->tx.ring->stats.yields++;
> +		q_vector->rx.ring->stats.yields++;
>   #endif
>   	return rc == IXGBE_QV_STATE_IDLE;
>   }
>

-- 
Best regards, Tikhomirov Pavel
Software Developer, Virtuozzo.

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
To: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>
Cc: <devel@openvz.org>
Subject: Re: [Intel-wired-lan] [PATCH v2] ixgbe: on recv increment rx.ring->stats.yields
Date: Fri, 25 Dec 2015 19:26:12 +0300	[thread overview]
Message-ID: <567D6E24.3030302@virtuozzo.com> (raw)
In-Reply-To: <1449842714-10284-1-git-send-email-ptikhomirov@virtuozzo.com>

Hi, please, let me know if I need to fix something else here.

On 12/11/2015 05:05 PM, Pavel Tikhomirov wrote:
> It seem to be non intentionaly changed to tx in
> commit adc810900a70 ("ixgbe: Refactor busy poll socket code to address
> multiple issues")
>
> Lock is taken from ixgbe_low_latency_recv, and there under this
> lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
> tx counter.
>
> Yield stats can be shown through ethtool:
> ethtool -S enp129s0 | grep yield
>
> v2: follow commit citing style
>
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
> ---
>   drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> index 1d21745..7656d46 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> @@ -451,7 +451,7 @@ static inline bool ixgbe_qv_lock_poll(struct ixgbe_q_vector *q_vector)
>   				IXGBE_QV_STATE_POLL);
>   #ifdef BP_EXTENDED_STATS
>   	if (rc != IXGBE_QV_STATE_IDLE)
> -		q_vector->tx.ring->stats.yields++;
> +		q_vector->rx.ring->stats.yields++;
>   #endif
>   	return rc == IXGBE_QV_STATE_IDLE;
>   }
>

-- 
Best regards, Tikhomirov Pavel
Software Developer, Virtuozzo.

  reply	other threads:[~2015-12-25 16:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11  7:24 [Intel-wired-lan] [PATCH] ixgbe: on recv increment rx.ring->stats.yields instead of tx Pavel Tikhomirov
2015-12-11  7:24 ` Pavel Tikhomirov
2015-12-11 13:47 ` [Intel-wired-lan] " Sergei Shtylyov
2015-12-11 13:47   ` Sergei Shtylyov
2015-12-11 14:05   ` [Intel-wired-lan] [PATCH v2] ixgbe: on recv increment rx.ring->stats.yields Pavel Tikhomirov
2015-12-11 14:05     ` Pavel Tikhomirov
2015-12-25 16:26     ` Pavel Tikhomirov [this message]
2015-12-25 16:26       ` [Intel-wired-lan] " Pavel Tikhomirov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567D6E24.3030302@virtuozzo.com \
    --to=ptikhomirov@virtuozzo.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.