From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from g2t4621.austin.hp.com ([15.73.212.80]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aCzFV-0008Bd-Gp for kexec@lists.infradead.org; Sun, 27 Dec 2015 00:31:50 +0000 Subject: Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search References: <1451081365-15190-1-git-send-email-toshi.kani@hpe.com> <1451081365-15190-14-git-send-email-toshi.kani@hpe.com> <20151226103804.GB21988@pd.tnic> From: Toshi Kani Message-ID: <567F315B.8080005@hpe.com> Date: Sat, 26 Dec 2015 17:31:23 -0700 MIME-Version: 1.0 In-Reply-To: <20151226103804.GB21988@pd.tnic> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Borislav Petkov Cc: linux-arch@vger.kernel.org, linux-nvdimm@lists.01.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, Dave Young , Dan Williams + cc: kexec list On 12/26/2015 3:38 AM, Borislav Petkov wrote: > On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote: >> Change to call walk_iomem_res_desc() for searching resource entries >> with the following names: >> "ACPI Tables" >> "ACPI Non-volatile Storage" >> "Persistent Memory (legacy)" >> "Crash kernel" >> >> Note, the caller of walk_iomem_res() with "GART" is left unchanged >> because this entry may be initialized by out-of-tree drivers, which >> do not have 'desc' set to IORES_DESC_GART. > > There's this out-of-tree bogus argument again. :\ > > Why do we care about out-of-tree drivers? > > You can just as well fix the "GART" case too and kill walk_iomem_res() > altogether... Right, but I do not see any "GART" case in the upstream code, so I cannot change it... Thanks, -Toshi _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshi Kani Subject: Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search Date: Sat, 26 Dec 2015 17:31:23 -0700 Message-ID: <567F315B.8080005@hpe.com> References: <1451081365-15190-1-git-send-email-toshi.kani@hpe.com> <1451081365-15190-14-git-send-email-toshi.kani@hpe.com> <20151226103804.GB21988@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151226103804.GB21988@pd.tnic> Sender: owner-linux-mm@kvack.org To: Borislav Petkov Cc: akpm@linux-foundation.org, linux-arch@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams , Dave Young , x86@kernel.org, linux-nvdimm@lists.01.org List-Id: linux-arch.vger.kernel.org + cc: kexec list On 12/26/2015 3:38 AM, Borislav Petkov wrote: > On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote: >> Change to call walk_iomem_res_desc() for searching resource entries >> with the following names: >> "ACPI Tables" >> "ACPI Non-volatile Storage" >> "Persistent Memory (legacy)" >> "Crash kernel" >> >> Note, the caller of walk_iomem_res() with "GART" is left unchanged >> because this entry may be initialized by out-of-tree drivers, which >> do not have 'desc' set to IORES_DESC_GART. > > There's this out-of-tree bogus argument again. :\ > > Why do we care about out-of-tree drivers? > > You can just as well fix the "GART" case too and kill walk_iomem_res() > altogether... Right, but I do not see any "GART" case in the upstream code, so I cannot change it... Thanks, -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g2t4625.austin.hp.com ([15.73.212.76]:58028 "EHLO g2t4625.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753438AbbL0Ab2 (ORCPT ); Sat, 26 Dec 2015 19:31:28 -0500 Subject: Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search References: <1451081365-15190-1-git-send-email-toshi.kani@hpe.com> <1451081365-15190-14-git-send-email-toshi.kani@hpe.com> <20151226103804.GB21988@pd.tnic> From: Toshi Kani Message-ID: <567F315B.8080005@hpe.com> Date: Sat, 26 Dec 2015 17:31:23 -0700 MIME-Version: 1.0 In-Reply-To: <20151226103804.GB21988@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Borislav Petkov Cc: akpm@linux-foundation.org, linux-arch@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams , Dave Young , x86@kernel.org, linux-nvdimm@lists.01.org Message-ID: <20151227003123.G7SNu4FvRO16r4xbKSFyWJ9qNzXZHNA7R7jMYwd4ydU@z> + cc: kexec list On 12/26/2015 3:38 AM, Borislav Petkov wrote: > On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote: >> Change to call walk_iomem_res_desc() for searching resource entries >> with the following names: >> "ACPI Tables" >> "ACPI Non-volatile Storage" >> "Persistent Memory (legacy)" >> "Crash kernel" >> >> Note, the caller of walk_iomem_res() with "GART" is left unchanged >> because this entry may be initialized by out-of-tree drivers, which >> do not have 'desc' set to IORES_DESC_GART. > > There's this out-of-tree bogus argument again. :\ > > Why do we care about out-of-tree drivers? > > You can just as well fix the "GART" case too and kill walk_iomem_res() > altogether... Right, but I do not see any "GART" case in the upstream code, so I cannot change it... Thanks, -Toshi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754156AbbL0Aba (ORCPT ); Sat, 26 Dec 2015 19:31:30 -0500 Received: from g2t4625.austin.hp.com ([15.73.212.76]:58028 "EHLO g2t4625.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753438AbbL0Ab2 (ORCPT ); Sat, 26 Dec 2015 19:31:28 -0500 Subject: Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search To: Borislav Petkov References: <1451081365-15190-1-git-send-email-toshi.kani@hpe.com> <1451081365-15190-14-git-send-email-toshi.kani@hpe.com> <20151226103804.GB21988@pd.tnic> Cc: akpm@linux-foundation.org, linux-arch@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams , Dave Young , x86@kernel.org, linux-nvdimm@ml01.01.org From: Toshi Kani Message-ID: <567F315B.8080005@hpe.com> Date: Sat, 26 Dec 2015 17:31:23 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151226103804.GB21988@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + cc: kexec list On 12/26/2015 3:38 AM, Borislav Petkov wrote: > On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote: >> Change to call walk_iomem_res_desc() for searching resource entries >> with the following names: >> "ACPI Tables" >> "ACPI Non-volatile Storage" >> "Persistent Memory (legacy)" >> "Crash kernel" >> >> Note, the caller of walk_iomem_res() with "GART" is left unchanged >> because this entry may be initialized by out-of-tree drivers, which >> do not have 'desc' set to IORES_DESC_GART. > > There's this out-of-tree bogus argument again. :\ > > Why do we care about out-of-tree drivers? > > You can just as well fix the "GART" case too and kill walk_iomem_res() > altogether... Right, but I do not see any "GART" case in the upstream code, so I cannot change it... Thanks, -Toshi