From mboxrd@z Thu Jan 1 00:00:00 1970 From: elfring@users.sourceforge.net (SF Markus Elfring) Date: Sun, 27 Dec 2015 08:58:33 +0100 Subject: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq In-Reply-To: References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr> <567EF188.7020203@cogentembedded.com> <567EF895.6080702@cogentembedded.com> Message-ID: <567F9A29.50202@users.sourceforge.net> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr > The error return value of platform_get_irq seems to often get dropped. How do you think about any more fine-tuning here? Commit message: * ? of the platform_get_irq() function seems to get dropped too often. * Why do you concentrate on a single function name? Do you plan to extend this source code analysis approach? > + at script:python r_report depends on report@ > +j0 << r.j0; > +j1 << r.j1; > +@@ > + > +msg = "Propagate return value of platform_get_irq around line %s." % (j1[0].line) Are there more unchecked return values which are interesting for further considerations? https://cwe.mitre.org/data/definitions/252.html Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 27 Dec 2015 07:58:33 +0000 Subject: Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq Message-Id: <567F9A29.50202@users.sourceforge.net> List-Id: References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr> <567EF188.7020203@cogentembedded.com> <567EF895.6080702@cogentembedded.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: cocci@systeme.lip6.fr > The error return value of platform_get_irq seems to often get dropped. How do you think about any more fine-tuning here? Commit message: * =85 of the platform_get_irq() function seems to get dropped too often. * Why do you concentrate on a single function name? Do you plan to extend this source code analysis approach? > +@script:python r_report depends on report@ > +j0 << r.j0; > +j1 << r.j1; > +@@ > + > +msg =3D "Propagate return value of platform_get_irq around line %s." % (= j1[0].line) Are there more unchecked return values which are interesting for further considerations? https://cwe.mitre.org/data/definitions/252.html Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq Date: Sun, 27 Dec 2015 08:58:33 +0100 Message-ID: <567F9A29.50202@users.sourceforge.net> References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr> <567EF188.7020203@cogentembedded.com> <567EF895.6080702@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: kernel-janitors-owner@vger.kernel.org To: Julia Lawall Cc: Coccinelle , LKML , kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, dri-devel@lists.freedesktop.org, Gilles Muller , Michal Marek , Nicolas Palix , Sergei Shtylyov List-Id: linux-i2c@vger.kernel.org > The error return value of platform_get_irq seems to often get dropped= =2E How do you think about any more fine-tuning here? Commit message: * =85 of the platform_get_irq() function seems to get dropped too often= =2E * Why do you concentrate on a single function name? Do you plan to extend this source code analysis approach? > +@script:python r_report depends on report@ > +j0 << r.j0; > +j1 << r.j1; > +@@ > + > +msg =3D "Propagate return value of platform_get_irq around line %s."= % (j1[0].line) Are there more unchecked return values which are interesting for further considerations? https://cwe.mitre.org/data/definitions/252.html Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janito= rs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.web.de ([212.227.15.3]:63241 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175AbbL0H6u (ORCPT ); Sun, 27 Dec 2015 02:58:50 -0500 Subject: Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq To: Julia Lawall References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr> <567EF188.7020203@cogentembedded.com> <567EF895.6080702@cogentembedded.com> Cc: Coccinelle , LKML , kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, dri-devel@lists.freedesktop.org, Gilles Muller , Michal Marek , Nicolas Palix , Sergei Shtylyov From: SF Markus Elfring Message-ID: <567F9A29.50202@users.sourceforge.net> Date: Sun, 27 Dec 2015 08:58:33 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: > The error return value of platform_get_irq seems to often get dropped. How do you think about any more fine-tuning here? Commit message: * … of the platform_get_irq() function seems to get dropped too often. * Why do you concentrate on a single function name? Do you plan to extend this source code analysis approach? > +@script:python r_report depends on report@ > +j0 << r.j0; > +j1 << r.j1; > +@@ > + > +msg = "Propagate return value of platform_get_irq around line %s." % (j1[0].line) Are there more unchecked return values which are interesting for further considerations? https://cwe.mitre.org/data/definitions/252.html Regards, Markus