From: Darren Salt <devspam-kUQ7/2e57v/LS5A4iEQ01Vpr/1R2p/CL@public.gmane.org>
To: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: amd-gfx list <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amd/display: Don't leak dc_stream_state.
Date: Tue, 12 Sep 2017 04:35:19 +0100 [thread overview]
Message-ID: <567FA538EC%devspam@moreofthesa.me.uk> (raw)
In-Reply-To: <CADnq5_ON-p=PJq54tdzVG++MtY9u7jXVmwYyG-rOZo-jp1agYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
I demand that Alex Deucher may or may not have written...
> On Fri, Sep 8, 2017 at 11:41 AM, Darren Salt <devspam@moreofthesa.me.uk>
wrote:
>> Noticed while playing “Valley”, which was causing some 8MB of leakage per
>> second. kmemleak listed many entries looking like this:
>>
>> unreferenced object 0xffff8802c2951800 (size 1024):
>> comm "Xorg", pid 2982, jiffies 4297410155 (age 392.787s)
>> hex dump (first 32 bytes):
>> 00 50 f9 0c 04 88 ff ff 98 08 00 00 00 00 00 00 .P..............
>> 80 07 00 00 00 00 00 00 58 00 00 00 2c 00 00 00 ........X...,...
>> backtrace:
>> [<ffffffff810cd4c3>] create_object+0x13c/0x261
>> [<ffffffff815abdc2>] kmemleak_alloc+0x20/0x3c
>> [<ffffffff810cad1d>] slab_post_alloc_hook+0x42/0x52
>> [<ffffffff810cb8e0>] kmem_cache_alloc+0x67/0x76
>> [<ffffffff813bbb54>] dc_create_stream_for_sink+0x24/0x1cf
[snip]
> Possibly the same issue as this?
> https://lists.freedesktop.org/archives/dri-devel/2017-August/150564.html
No. I've tested that patch in place of mine, and kmemleak shows the leaks
again.
The offending patch is a5a159d077be / c4e2a09e8414 “drm/amd/display: Refactor
atomic check”: it allocates new_stream but then, in various circumstances,
fails to release it.
If that allocation goes away then I expect that so can this fix.
--
| _ | Darren Salt, using Debian GNU/Linux (and Android)
| ( ) |
| X | ASCII Ribbon campaign against HTML e-mail
| / \ |
Force has no place where there is need of skill.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-09-12 3:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 15:41 [PATCH] drm/amd/display: Don't leak dc_stream_state Darren Salt
[not found] ` <20170908154134.8657-1-devspam-kUQ7/2e57v/LS5A4iEQ01Vpr/1R2p/CL@public.gmane.org>
2017-09-12 3:06 ` Alex Deucher
[not found] ` <CADnq5_ON-p=PJq54tdzVG++MtY9u7jXVmwYyG-rOZo-jp1agYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-12 3:35 ` Darren Salt [this message]
2017-09-12 14:37 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567FA538EC%devspam@moreofthesa.me.uk \
--to=devspam-kuq7/2e57v/ls5a4ieq01vpr/1r2p/cl@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.