From mboxrd@z Thu Jan 1 00:00:00 1970 From: elfring@users.sourceforge.net (SF Markus Elfring) Date: Sun, 27 Dec 2015 17:24:02 +0100 Subject: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq In-Reply-To: References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr> <567EF188.7020203@cogentembedded.com> <567EF895.6080702@cogentembedded.com> <567F9A29.50202@users.sourceforge.net> Message-ID: <568010A2.3000902@users.sourceforge.net> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr >> https://cwe.mitre.org/data/definitions/252.html > > The value is not unchecked. Would you like to express any stronger relationship between the function call example and the occurrence of an if statement by the discussed SmPL script? > I made a specific rule because the specific problem is quite common. Can it become also interesting to generalise this search pattern? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 27 Dec 2015 16:24:02 +0000 Subject: Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq Message-Id: <568010A2.3000902@users.sourceforge.net> List-Id: References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr> <567EF188.7020203@cogentembedded.com> <567EF895.6080702@cogentembedded.com> <567F9A29.50202@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cocci@systeme.lip6.fr >> https://cwe.mitre.org/data/definitions/252.html > > The value is not unchecked. Would you like to express any stronger relationship between the function call example and the occurrence of an if statement by the discussed SmPL script? > I made a specific rule because the specific problem is quite common. Can it become also interesting to generalise this search pattern? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq Date: Sun, 27 Dec 2015 17:24:02 +0100 Message-ID: <568010A2.3000902@users.sourceforge.net> References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr> <567EF188.7020203@cogentembedded.com> <567EF895.6080702@cogentembedded.com> <567F9A29.50202@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Julia Lawall Cc: Sergei Shtylyov , Gilles Muller , netdev@vger.kernel.org, Nicolas Palix , kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, linux-spi@vger.kernel.org, Michal Marek , linux-i2c@vger.kernel.org, Coccinelle , linux-media@vger.kernel.org List-Id: linux-i2c@vger.kernel.org Pj4gaHR0cHM6Ly9jd2UubWl0cmUub3JnL2RhdGEvZGVmaW5pdGlvbnMvMjUyLmh0bWwKPiAKPiBU aGUgdmFsdWUgaXMgbm90IHVuY2hlY2tlZC4KCldvdWxkIHlvdSBsaWtlIHRvIGV4cHJlc3MgYW55 IHN0cm9uZ2VyIHJlbGF0aW9uc2hpcCBiZXR3ZWVuCnRoZSBmdW5jdGlvbiBjYWxsIGV4YW1wbGUg YW5kIHRoZSBvY2N1cnJlbmNlIG9mIGFuIGlmIHN0YXRlbWVudApieSB0aGUgZGlzY3Vzc2VkIFNt UEwgc2NyaXB0PwoKCj4gSSBtYWRlIGEgc3BlY2lmaWMgcnVsZSBiZWNhdXNlIHRoZSBzcGVjaWZp YyBwcm9ibGVtIGlzIHF1aXRlIGNvbW1vbi4KCkNhbiBpdCBiZWNvbWUgYWxzbyBpbnRlcmVzdGlu ZyB0byBnZW5lcmFsaXNlIHRoaXMgc2VhcmNoIHBhdHRlcm4/CgpSZWdhcmRzLApNYXJrdXMKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.web.de ([212.227.15.14]:61043 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751129AbbL0QYU (ORCPT ); Sun, 27 Dec 2015 11:24:20 -0500 Subject: Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq To: Julia Lawall References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr> <567EF188.7020203@cogentembedded.com> <567EF895.6080702@cogentembedded.com> <567F9A29.50202@users.sourceforge.net> Cc: Coccinelle , LKML , kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, dri-devel@lists.freedesktop.org, Gilles Muller , Michal Marek , Nicolas Palix , Sergei Shtylyov From: SF Markus Elfring Message-ID: <568010A2.3000902@users.sourceforge.net> Date: Sun, 27 Dec 2015 17:24:02 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: >> https://cwe.mitre.org/data/definitions/252.html > > The value is not unchecked. Would you like to express any stronger relationship between the function call example and the occurrence of an if statement by the discussed SmPL script? > I made a specific rule because the specific problem is quite common. Can it become also interesting to generalise this search pattern? Regards, Markus