All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	stable@dpdk.org, "Jiale, SongX" <songx.jiale@intel.com>
Subject: Re: [PATCH] telemetry: fix potential connection issue
Date: Sun, 07 Jul 2024 15:11:48 +0200	[thread overview]
Message-ID: <5680259.hf2xvdu6PP@thomas> (raw)
In-Reply-To: <BN0PR11MB57436B6B12B1E6271B88D0B8E7D62@BN0PR11MB5743.namprd11.prod.outlook.com>

26/06/2024 04:13, Jiale, SongX:
> From: Zhichao Zeng <zhichaox.zeng@intel.com>
> > 
> > For calling memcpy when the source and destination addresses are the same,
> > there is a small probability that there will be a copy error issue in some
> > environments, resulting in a failure to connect.
> > 
> > This patch uses memmove instead of memcpy to avoid this issue.
> > 
> > Fixes: b80fe1805eee ("telemetry: introduce backward compatibility")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
> > ---
> Tested-by: Song Jiale <songx.jiale@intel.com>

It would be cleaner to do a proper parsing before doing any copy (strlcpy, memcpy/memmove).

dirty code dirty fixed for now
Applied




      reply	other threads:[~2024-07-07 14:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21  2:40 [PATCH] telemetry: fix potential connection issue Zhichao Zeng
2024-06-26  2:13 ` Jiale, SongX
2024-07-07 13:11   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5680259.hf2xvdu6PP@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=songx.jiale@intel.com \
    --cc=stable@dpdk.org \
    --cc=zhichaox.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.