From: Mason <slash.tmp@free.fr>
To: Florian Fainelli <f.fainelli@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: netdev@vger.kernel.org, Mans Rullgard <mans@mansr.com>
Subject: Re: [PATCH 2/4] net: phy: at803x: Allow specifying the RGMII RX clock delay via phy mode
Date: Sun, 27 Dec 2015 21:22:48 +0100 [thread overview]
Message-ID: <56804898.1030902@free.fr> (raw)
In-Reply-To: <567F5AD5.40004@gmail.com>
On 27/12/2015 04:28, Florian Fainelli wrote:
> Le 25/12/2015 16:27, Martin Blumenstingl wrote:
>
>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
>> index f566b6e..0b262a2 100644
>> --- a/drivers/net/phy/at803x.c
>> +++ b/drivers/net/phy/at803x.c
>> @@ -36,8 +36,10 @@
>> #define AT803X_INSR 0x0013
>> #define AT803X_DEBUG_ADDR 0x1D
>> #define AT803X_DEBUG_DATA 0x1E
>> -#define AT803X_DEBUG_SYSTEM_MODE_CTRL 0x05
>> -#define AT803X_DEBUG_RGMII_TX_CLK_DLY BIT(8)
>> +#define AT803X_DEBUG_REG_0 0x00
>
> Seems like the previous register name might have been clearer that the
> new name you suggest here, did that come from a different GPL tarball or
> documentation?
http://www.redeszone.net/app/uploads/2014/04/AR8035.pdf
According to the 8035 data sheet, the debug register at offset 0
is just "Debug register 0". In fact, the only non-reserved bit is
"rgmii rx clock delay enable/disable"
So the SYSTEM_MODE_CTRL name is misleading. Unless the register
has different semantics on the other PHYs?
Regards.
next prev parent reply other threads:[~2015-12-27 20:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-26 0:26 Small improvements for the at803x PHY driver Martin Blumenstingl
2015-12-26 0:26 ` [PATCH 1/4] net: phy: at803x: Don't set gbit features for the AR8030 phy Martin Blumenstingl
2015-12-27 3:24 ` Florian Fainelli
2015-12-26 0:27 ` [PATCH 2/4] net: phy: at803x: Allow specifying the RGMII RX clock delay via phy mode Martin Blumenstingl
2015-12-27 3:28 ` Florian Fainelli
2015-12-27 15:15 ` Martin Blumenstingl
2015-12-27 20:22 ` Mason [this message]
2016-01-04 21:17 ` Martin Blumenstingl
2016-01-04 22:05 ` Florian Fainelli
2015-12-26 0:27 ` [PATCH 3/4] net: phy: at803x: Clean up duplicate register definitions Martin Blumenstingl
2015-12-27 3:28 ` Florian Fainelli
2015-12-26 0:27 ` [PATCH 4/4] net: phy: at803x: Add the interrupt register bit definitions Martin Blumenstingl
2015-12-27 3:29 ` Florian Fainelli
2015-12-26 11:57 ` Small improvements for the at803x PHY driver Mason
2015-12-27 3:29 ` Florian Fainelli
2016-01-15 0:57 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56804898.1030902@free.fr \
--to=slash.tmp@free.fr \
--cc=f.fainelli@gmail.com \
--cc=mans@mansr.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.