All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] altera_qspi: show erase progress
Date: Mon, 28 Dec 2015 16:04:55 +0800	[thread overview]
Message-ID: <5680ED27.1010800@wytron.com.tw> (raw)
In-Reply-To: <201512280635.06288.marex@denx.de>

Hi Marek,

On 2015?12?28? 13:35, Marek Vasut wrote:
> On Monday, December 28, 2015 at 02:17:46 AM, Thomas Chou wrote:
>> Hi Marek,
>>
>> On 2015?12?25? 17:58, Marek Vasut wrote:
>>> On Friday, December 25, 2015 at 09:33:52 AM, Thomas Chou wrote:
>>>> Hi Marek,
>>>>
>>>> On 2015?12?25? 12:08, Marek Vasut wrote:
>>>>>> Well, it is only a putc() which is plain and simple.
>>>>>
>>>>> Sure, but then I still don't understand why this cannot be in the
>>>>> common code.
>>>>
>>>> Yes, it can be in the common code. Do you have an idea how should it
>>>> look like?
>>>
>>> No, I don't, I am not a CFI expert, sorry.
>>
>> Then I shall push these first and find way to put it to common code some
>> time later. Thanks.
>
> Is this any way to deal with feedback ? Why don't you put it into flash_erase()
> for example, in drivers/mtd/cfi_flash.c ?

Though altera-qspi works like CFI flash, it is not CFI flash as it does 
not have CFI info. It is a separate driver to cfi_flash.c.

Both drivers and many other parallel flash drivers under the board/arch 
directories are called by common/cmd_flash.c, which is very old and 
somewhat nasty. It could be the place for common feedback. But this is 
too far and deeply involved. I wanted to touch it a month ago, made some 
patches but withdrew then.

Best regards,
Thomas

  reply	other threads:[~2015-12-28  8:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-24  0:51 [U-Boot] [PATCH 1/5] altera_qspi: call callback even if the erase failed Thomas Chou
2015-12-24  0:51 ` [U-Boot] [PATCH 2/5] altera_qspi: set fail_addr for erase ops Thomas Chou
2015-12-28  1:34   ` Thomas Chou
2015-12-24  0:51 ` [U-Boot] [PATCH 3/5] altera_qspi: skip erase if the sector is blank Thomas Chou
2015-12-24  1:28   ` Marek Vasut
2015-12-24  2:23     ` Thomas Chou
2015-12-24  3:01       ` Marek Vasut
2015-12-24  3:08         ` Thomas Chou
2015-12-24  3:43           ` Marek Vasut
2015-12-28  1:34   ` Thomas Chou
2015-12-24  0:51 ` [U-Boot] [PATCH 4/5] altera_qspi: show erase progress Thomas Chou
2015-12-24  1:29   ` Marek Vasut
2015-12-24  2:50     ` Thomas Chou
2015-12-24  3:02       ` Marek Vasut
2015-12-24  3:26         ` Thomas Chou
2015-12-24  3:42           ` Marek Vasut
2015-12-24  5:24             ` Thomas Chou
2015-12-24  5:37               ` Marek Vasut
2015-12-25  0:12                 ` Thomas Chou
2015-12-25  4:08                   ` Marek Vasut
2015-12-25  8:33                     ` Thomas Chou
2015-12-25  9:58                       ` Marek Vasut
2015-12-28  1:17                         ` Thomas Chou
2015-12-28  5:35                           ` Marek Vasut
2015-12-28  8:04                             ` Thomas Chou [this message]
2015-12-28 12:40                               ` Marek Vasut
2015-12-28  1:35   ` Thomas Chou
2015-12-24  0:51 ` [U-Boot] [PATCH 5/5] altera_qspi: allow ctrl-c to abort the erase ops Thomas Chou
2015-12-28  1:35   ` Thomas Chou
2015-12-28  1:34 ` [U-Boot] [PATCH 1/5] altera_qspi: call callback even if the erase failed Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5680ED27.1010800@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.