From: Jens Axboe <axboe@fb.com>
To: Rabin Vincent <rabin@rab.in>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] null_blk: don't enable irqs when in irq
Date: Mon, 28 Dec 2015 13:08:41 -0700 [thread overview]
Message-ID: <568196C9.5050903@fb.com> (raw)
In-Reply-To: <20151228195159.GA5330@debian>
On 12/28/2015 12:51 PM, Rabin Vincent wrote:
> On Mon, Dec 28, 2015 at 12:11:17PM -0700, Jens Axboe wrote:
>> On 12/28/2015 12:07 PM, Rabin Vincent wrote:
>>> On Mon, Dec 28, 2015 at 11:52:24AM -0700, Jens Axboe wrote:
>>>> Something like this should work, can you test it?
>>>
>>> Spits out a bunch of the following. It's this assertion:
>>>
>>> static inline void queue_lockdep_assert_held(struct request_queue *q)
>>> {
>>> if (q->queue_lock)
>>> lockdep_assert_held(q->queue_lock);
>>> }
>>
>> Ah right, we clear the stopped flag. This one should be better.
>
> Yes, this one appears to work fine.
>
> Tested-by: Rabin Vincent <rabin@rab.in>
Thanks for testing, I've added it.
--
Jens Axboe
prev parent reply other threads:[~2015-12-28 20:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-25 14:26 [PATCH] null_blk: don't enable irqs when in irq Rabin Vincent
2015-12-26 4:03 ` Jens Axboe
2015-12-28 18:52 ` Jens Axboe
2015-12-28 19:07 ` Rabin Vincent
2015-12-28 19:11 ` Jens Axboe
2015-12-28 19:51 ` Rabin Vincent
2015-12-28 20:08 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568196C9.5050903@fb.com \
--to=axboe@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.