From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] include/linux/amd-iommu.h: Move to arch/x86/include/asm Date: Tue, 29 Dec 2015 04:40:27 +0800 Message-ID: <56819E3B.20506@emindsoft.com.cn> References: <1451136392-22638-1-git-send-email-chengang@emindsoft.com.cn> <20151228155153.GM18805@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20151228155153.GM18805@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org To: Joerg Roedel Cc: akpm@linux-foundation.org, oded.gabbay@gmail.com, airlied@linux.ie, joe@perches.com, jslaby@suse.com, gregkh@linuxfoundation.org, davem@davemloft.net, mchehab@osg.samsung.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 12/28/15 23:51, Joerg Roedel wrote: > On Sat, Dec 26, 2015 at 09:26:32PM +0800, chengang@emindsoft.com.cn w= rote: >> >> It is architecture specific mechanism header, not generic header, so >> move it to arch/x86/include/asm. >=20 > There might be future non-x86 hardware which also has an amd iommu, s= o > the header file should stay where it is for now. > =46or me, amd-iommu.h is architecture specific, for this kind of header= s, if it is used by most of archs, it will be in "include/asm-generic". If it is used by several archs, it will be in "arch/*/include/asm/". So for me, at present, it is only used by x86, so is move to "arch/x86/ include/asm/"; if another archs want it, they can copy one. If quite a few archs (e.g. > 3 archs) need it, move it to "include/asm-generic". Thanks. --=20 Chen Gang (=E9=99=88=E5=88=9A) Open, share, and attitude like air, water, and life which God blessed