From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milo Kim Subject: Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Date: Tue, 29 Dec 2015 09:45:28 +0900 Message-ID: <5681D7A8.2030101@ti.com> References: <1450868319-20513-1-git-send-email-contact@paulk.fr> <1450868319-20513-5-git-send-email-contact@paulk.fr> <20151223115632.GS16023@sirena.org.uk> <568088B4.6090207@ti.com> <1451342963.14631.13.camel@collins> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1451342963.14631.13.camel@collins> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Paul Kocialkowski Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , Tony Lindgren , linux-kernel@vger.kernel.org, Rob Herring , Liam Girdwood , Mark Brown , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Kumar Gala , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org SGkgUGF1bCwKCk9uIDI5LzEyLzE1IDA3OjQ5LCBQYXVsIEtvY2lhbGtvd3NraSB3cm90ZToKPiBI aSBNaWxvLCB0aGFua3MgZm9yIHRoZSByZXZpZXcsCj4KPiBMZSBsdW5kaSAyOCBkw6ljZW1icmUg MjAxNSDDoCAwOTo1NiArMDkwMCwgTWlsbyBLaW0gYSDDqWNyaXQgOgo+PiBIaSBQYXVsLAo+Pgo+ PiBPbiAyMy8xMi8xNSAyMDo1NiwgTWFyayBCcm93biB3cm90ZToKPj4+IE9uIFdlZCwgRGVjIDIz LCAyMDE1IGF0IDExOjU4OjM3QU0gKzAxMDAsIFBhdWwgS29jaWFsa293c2tpIHdyb3RlOgo+Pj4K Pj4+PiArCWdwaW8gPSBscC0+cGRhdGEtPmVuYWJsZV9ncGlvOwo+Pj4+ICsJaWYgKCFncGlvX2lz X3ZhbGlkKGdwaW8pKQo+Pj4+ICsJCXJldHVybiAwOwo+Pj4+ICsKPj4+PiArCS8qIEFsd2F5cyBz ZXQgZW5hYmxlIEdQSU8gaGlnaC4gKi8KPj4+PiArCXJldCA9IGRldm1fZ3Bpb19yZXF1ZXN0X29u ZShscC0+ZGV2LCBncGlvLCBHUElPRl9PVVRfSU5JVF9ISUdILCAiTFA4NzJYIEVOIik7Cj4+Pj4g KwlpZiAocmV0KSB7Cj4+Pj4gKwkJZGV2X2VycihscC0+ZGV2LCAiZ3BpbyByZXF1ZXN0IGVycjog JWRcbiIsIHJldCk7Cj4+Pj4gKwkJcmV0dXJuIHJldDsKPj4+PiArCX0KPj4+Cj4+PiBUaGlzIGlz bid0IHJlYWxseSBhZGRpbmcgc3VwcG9ydCBmb3IgdGhlIGVuYWJsZSBHUElPIGFzIHRoZSBjaGFu Z2Vsb2cKPj4+IHN1Z2dlc3RzLCBpdCdzIHJlcXVlc3RpbmcgYnV0IG5vdCBtYW5hZ2luZyB0aGUg R1BJTy4gIFNpbmNlIHRoZXJlIGlzCj4+PiBjb3JlIHN1cHBvcnQgZm9yIG1hbmdpbmcgZW5hYmxl IEdQSU9zIHRoaXMgc2VlbXMgZXNwZWNpYWxseSBzaWxseSwKPj4+IHBsZWFzZSB0ZWxsIHRoZSBj b3JlIGFib3V0IHRoZSBHUElPIGFuZCB0aGVuIGl0IHdpbGwgd29yayBhdCBydW50aW1lCj4+PiB0 b28uCj4+Pgo+Pgo+PiBXaXRoIHJlZmVyZW5jZSB0byBteSBwcmV2aW91cyBtYWlsLCBleHRlcm5h bCBHUElPcyBmb3IgTERPMyBhbmQgQlVDSzIgaW4KPj4gTFA4NzI1IGNhbiBiZSBzcGVjaWZpZWQg dGhyb3VnaCByZWd1bGF0b3JfY29uZmlnLmVuYV9ncGlvLiBCVUNLMiBvbmx5Cj4+IGNhbiBiZSBj b250cm9sbGVkIGJ5IGV4dGVybmFsIHBpbiB3aGVuIENPTkZJRyBwaW4gaXMgZ3JvdW5kZWQuCj4+ Cj4+IFBsZWFzZSBzZWUgdGhlIGRlc2NyaXB0aW9uIGF0IHBhZ2UgNSBvZiB0aGUgZGF0YXNoZWV0 Lgo+Pgo+PiAJaHR0cDovL3d3dy50aS5jb20vbGl0L2RzL3N5bWxpbmsvbHA4NzI1LnBkZgo+Cj4g QWZ0ZXIgcmVhZGluZyB0aGUgZGF0YXNoZWV0cyB0aG9yb3VnaGx5LCBpdCBzZWVtcyB0byBtZSB0 aGF0IGZvciB0aGUKPiBscDg3MjAsIHRoZSBFTiBwaW4gaXMgdXNlZCB0byBlbmFibGUgdGhlIHJl Z3VsYXRvcnMgb3V0cHV0LCB3aGljaCBpcyBhCj4gZ29vZCBmaXQgZm9yIHRoZSBjb3JlIHJlZ3Vs YXRvciBHUElPIGZyYW1ld29yaywgYXMgdGhlcmUgaXMgbm8gcmVhc29uIHRvCj4ga2VlcCBpdCBv biB3aGVuIG5vIHJlZ3VsYXRvciBpcyBpbiB1c2UuIFRoZSBzZXJpYWwgaW50ZXJmYWNlIGlzIGFs cmVhZHkKPiBhdmFpbGFibGUgd2hlbiBFTj0wIGFuZCByZWd1bGF0b3JzIGNhbiBiZSBjb25maWd1 cmVkIGluIHRoYXQgc3RhdGUuIFRoZQo+IGxwODcyNSBzZWVtcyBzZWVtcyB0byBiZWhhdmUgdGhl IHNhbWUgd2hlbiBDT05GSUc9MCAodGhlIGRhdGFzaGVldAo+IGNsZWFybHkgc3RhdGVzOiAiQ09O RklHPTA6IEVOPTEgdHVybnMgb24gb3V0cHV0cyBvciBzdGFuZGJ5IG1vZGUgaWYKPiBFTj0wIiku IE9uIHRoZSBvdGhlciBoYW5kLCBpdCBpcyBpbmRlZWQgdXNlZCBhcyBhIHBvd2VyLW9uIHBpbiB3 aGVuCj4gQ09ORklHPTEuCgpJIHRoaW5rIGl0J3MgZGlmZmVyZW50IHVzZSBjYXNlLiBMUDg3MjAv NSBhcmUgZGVzaWduZWQgZm9yIHN5c3RlbSBQTVUsIApzbyBzb21lIHJlZ3VsYXRvcnMgYXJlIGVu YWJsZWQgYnkgZGVmYXVsdCBhZnRlciB0aGUgZGV2aWNlIGlzIG9uLiBFTiBwaW4gCmlzIHVzZWQg Zm9yIHR1cm5pbmcgb24vb2ZmIHRoZSBjaGlwLiBUaGlzIHBpbiBkb2VzIG5vdCBjb250cm9sIHJl Z3VsYXRvciAKb3V0cHV0cyBkaXJlY3RseS4gSXQncyBzZXBhcmF0ZSBmdW5jdGlvbmFsIGJsb2Nr IGluIHRoZSBzaWxpY29uLgoKT24gdGhlIG90aGVyIGhhbmQsICdlbmFfZ3BpbycgaXMgdXNlZCBm b3IgZWFjaCByZWd1bGF0b3IgY29udHJvbCBpdHNlbGYuCkZvciBleGFtcGxlLCBXTTg5OTQgaGFz IHR3byBMRE9zIHdoaWNoIGFyZSBjb250cm9sbGVkIGJ5IGV4dGVybmFsIHBpbnMuIApMRE9zIGFy ZSBlbmFibGVkL2Rpc2FibGVkIHRocm91Z2ggTERPMUVOQSBhbmQgTERPMkVOQSBwaW5zLiBJbiB0 aGlzIApjYXNlLCAnZW5hX2dwaW8nIGlzIHVzZWQuCgoJaHR0cDovL3d3dy5jaXJydXMuY29tL2Vu L3B1YnMvcHJvRGF0YXNoZWV0L1dNODk5NF92NC40LnBkZgoJKHBsZWFzZSByZWZlciB0byBwYWdl IDIyNCBhbmQgMjI1KQoKQmVzdCByZWdhcmRzLApNaWxvCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: milo.kim@ti.com (Milo Kim) Date: Tue, 29 Dec 2015 09:45:28 +0900 Subject: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support In-Reply-To: <1451342963.14631.13.camel@collins> References: <1450868319-20513-1-git-send-email-contact@paulk.fr> <1450868319-20513-5-git-send-email-contact@paulk.fr> <20151223115632.GS16023@sirena.org.uk> <568088B4.6090207@ti.com> <1451342963.14631.13.camel@collins> Message-ID: <5681D7A8.2030101@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Paul, On 29/12/15 07:49, Paul Kocialkowski wrote: > Hi Milo, thanks for the review, > > Le lundi 28 d?cembre 2015 ? 09:56 +0900, Milo Kim a ?crit : >> Hi Paul, >> >> On 23/12/15 20:56, Mark Brown wrote: >>> On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: >>> >>>> + gpio = lp->pdata->enable_gpio; >>>> + if (!gpio_is_valid(gpio)) >>>> + return 0; >>>> + >>>> + /* Always set enable GPIO high. */ >>>> + ret = devm_gpio_request_one(lp->dev, gpio, GPIOF_OUT_INIT_HIGH, "LP872X EN"); >>>> + if (ret) { >>>> + dev_err(lp->dev, "gpio request err: %d\n", ret); >>>> + return ret; >>>> + } >>> >>> This isn't really adding support for the enable GPIO as the changelog >>> suggests, it's requesting but not managing the GPIO. Since there is >>> core support for manging enable GPIOs this seems especially silly, >>> please tell the core about the GPIO and then it will work at runtime >>> too. >>> >> >> With reference to my previous mail, external GPIOs for LDO3 and BUCK2 in >> LP8725 can be specified through regulator_config.ena_gpio. BUCK2 only >> can be controlled by external pin when CONFIG pin is grounded. >> >> Please see the description at page 5 of the datasheet. >> >> http://www.ti.com/lit/ds/symlink/lp8725.pdf > > After reading the datasheets thoroughly, it seems to me that for the > lp8720, the EN pin is used to enable the regulators output, which is a > good fit for the core regulator GPIO framework, as there is no reason to > keep it on when no regulator is in use. The serial interface is already > available when EN=0 and regulators can be configured in that state. The > lp8725 seems seems to behave the same when CONFIG=0 (the datasheet > clearly states: "CONFIG=0: EN=1 turns on outputs or standby mode if > EN=0"). On the other hand, it is indeed used as a power-on pin when > CONFIG=1. I think it's different use case. LP8720/5 are designed for system PMU, so some regulators are enabled by default after the device is on. EN pin is used for turning on/off the chip. This pin does not control regulator outputs directly. It's separate functional block in the silicon. On the other hand, 'ena_gpio' is used for each regulator control itself. For example, WM8994 has two LDOs which are controlled by external pins. LDOs are enabled/disabled through LDO1ENA and LDO2ENA pins. In this case, 'ena_gpio' is used. http://www.cirrus.com/en/pubs/proDatasheet/WM8994_v4.4.pdf (please refer to page 224 and 225) Best regards, Milo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752969AbbL2ApX (ORCPT ); Mon, 28 Dec 2015 19:45:23 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:54355 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbbL2ApV (ORCPT ); Mon, 28 Dec 2015 19:45:21 -0500 Subject: Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support To: Paul Kocialkowski References: <1450868319-20513-1-git-send-email-contact@paulk.fr> <1450868319-20513-5-git-send-email-contact@paulk.fr> <20151223115632.GS16023@sirena.org.uk> <568088B4.6090207@ti.com> <1451342963.14631.13.camel@collins> CC: Mark Brown , , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Tony Lindgren , Liam Girdwood , , , From: Milo Kim Message-ID: <5681D7A8.2030101@ti.com> Date: Tue, 29 Dec 2015 09:45:28 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1451342963.14631.13.camel@collins> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 29/12/15 07:49, Paul Kocialkowski wrote: > Hi Milo, thanks for the review, > > Le lundi 28 décembre 2015 à 09:56 +0900, Milo Kim a écrit : >> Hi Paul, >> >> On 23/12/15 20:56, Mark Brown wrote: >>> On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: >>> >>>> + gpio = lp->pdata->enable_gpio; >>>> + if (!gpio_is_valid(gpio)) >>>> + return 0; >>>> + >>>> + /* Always set enable GPIO high. */ >>>> + ret = devm_gpio_request_one(lp->dev, gpio, GPIOF_OUT_INIT_HIGH, "LP872X EN"); >>>> + if (ret) { >>>> + dev_err(lp->dev, "gpio request err: %d\n", ret); >>>> + return ret; >>>> + } >>> >>> This isn't really adding support for the enable GPIO as the changelog >>> suggests, it's requesting but not managing the GPIO. Since there is >>> core support for manging enable GPIOs this seems especially silly, >>> please tell the core about the GPIO and then it will work at runtime >>> too. >>> >> >> With reference to my previous mail, external GPIOs for LDO3 and BUCK2 in >> LP8725 can be specified through regulator_config.ena_gpio. BUCK2 only >> can be controlled by external pin when CONFIG pin is grounded. >> >> Please see the description at page 5 of the datasheet. >> >> http://www.ti.com/lit/ds/symlink/lp8725.pdf > > After reading the datasheets thoroughly, it seems to me that for the > lp8720, the EN pin is used to enable the regulators output, which is a > good fit for the core regulator GPIO framework, as there is no reason to > keep it on when no regulator is in use. The serial interface is already > available when EN=0 and regulators can be configured in that state. The > lp8725 seems seems to behave the same when CONFIG=0 (the datasheet > clearly states: "CONFIG=0: EN=1 turns on outputs or standby mode if > EN=0"). On the other hand, it is indeed used as a power-on pin when > CONFIG=1. I think it's different use case. LP8720/5 are designed for system PMU, so some regulators are enabled by default after the device is on. EN pin is used for turning on/off the chip. This pin does not control regulator outputs directly. It's separate functional block in the silicon. On the other hand, 'ena_gpio' is used for each regulator control itself. For example, WM8994 has two LDOs which are controlled by external pins. LDOs are enabled/disabled through LDO1ENA and LDO2ENA pins. In this case, 'ena_gpio' is used. http://www.cirrus.com/en/pubs/proDatasheet/WM8994_v4.4.pdf (please refer to page 224 and 225) Best regards, Milo