From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/6] IB/uapi: expose uverbs WC opcodes
Date: Tue, 29 Dec 2015 13:02:54 +0200 [thread overview]
Message-ID: <5682685E.90700@dev.mellanox.co.il> (raw)
In-Reply-To: <20151227061202.GB8501-2ukJVAZIZ/Y@public.gmane.org>
>> + IB_WC_SEND = IB_UVERBS_WC_SEND,
>> + IB_WC_RDMA_WRITE = IB_UVERBS_WC_RDMA_WRITE,
>> + IB_WC_RDMA_READ = IB_UVERBS_WC_RDMA_READ,
>> + IB_WC_COMP_SWAP = IB_UVERBS_WC_COMP_SWAP,
>> + IB_WC_FETCH_ADD = IB_UVERBS_WC_FETCH_ADD,
>> + IB_WC_LSO = IB_UVERBS_WC_SEND_END,
>> + IB_WC_LOCAL_INV = IB_UVERBS_WC_SEND_END + 1,
>> + IB_WC_REG_MR = IB_UVERBS_WC_SEND_END + 2,
>> + IB_WC_MASKED_COMP_SWAP = IB_UVERBS_WC_SEND_END + 3,
>> + IB_WC_MASKED_FETCH_ADD = IB_UVERBS_WC_SEND_END + 4,
> As you did it in the first patch, just don't assign after IB_WC_LOCAL_INV.
> Compiler will handle IB_UVERS_WC_SEND_END + X calculations by itself.
I disagree, I'd say its better to keep the code verbosity level here...
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-29 11:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 14:39 start moving user space visible constants to uapi headers Christoph Hellwig
[not found] ` <1450967967-12479-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-12-24 14:39 ` [PATCH 1/6] IB/uapi: expose uverbs WR opcodes Christoph Hellwig
[not found] ` <1450967967-12479-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-12-27 6:04 ` Leon Romanovsky
2015-12-24 14:39 ` [PATCH 2/6] IB/uapi: expose uverbs send WR flags Christoph Hellwig
[not found] ` <1450967967-12479-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-12-31 14:45 ` Haggai Eran
2015-12-24 14:39 ` [PATCH 3/6] IB/uapi: expose uverbs WC opcodes Christoph Hellwig
[not found] ` <1450967967-12479-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-12-27 6:12 ` Leon Romanovsky
[not found] ` <20151227061202.GB8501-2ukJVAZIZ/Y@public.gmane.org>
2015-12-29 11:02 ` Sagi Grimberg [this message]
[not found] ` <5682685E.90700-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-12-30 9:44 ` Christoph Hellwig
[not found] ` <20151230094429.GD12904-jcswGhMUV9g@public.gmane.org>
2015-12-30 11:28 ` Leon Romanovsky
2015-12-24 14:39 ` [PATCH 4/6] IB/uapi: expose uverbs WC flags Christoph Hellwig
[not found] ` <1450967967-12479-5-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-12-27 6:15 ` Leon Romanovsky
[not found] ` <20151227061545.GC8501-2ukJVAZIZ/Y@public.gmane.org>
2015-12-29 11:04 ` Sagi Grimberg
2015-12-24 14:39 ` [PATCH 5/6] IB/uapi: expose uverbs WC status codes Christoph Hellwig
[not found] ` <1450967967-12479-6-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-12-27 6:17 ` Leon Romanovsky
2015-12-24 14:39 ` [PATCH 6/6] IB/uapi: expose device capability flags Christoph Hellwig
[not found] ` <1450967967-12479-7-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-12-31 15:17 ` Haggai Eran
2016-01-04 17:02 ` start moving user space visible constants to uapi headers Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5682685E.90700@dev.mellanox.co.il \
--to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.