All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 04/10] tiny-printf: Avoid printing NULL strings
Date: Tue, 29 Dec 2015 14:23:41 +0100	[thread overview]
Message-ID: <5682895D.20709@denx.de> (raw)
In-Reply-To: <1451391772-6203-5-git-send-email-sjg@chromium.org>

On 29.12.2015 13:22, Simon Glass wrote:
> Add a check for NULL strings to avoid printing junk to the console.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   lib/tiny-printf.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c
> index 403b134..efe5c25 100644
> --- a/lib/tiny-printf.c
> +++ b/lib/tiny-printf.c
> @@ -108,8 +108,10 @@ int vprintf(const char *fmt, va_list va)
>   				w--;
>   			while (w-- > 0)
>   				putc(lz ? '0' : ' ');
> -			while ((ch = *p++))
> -				putc(ch);
> +			if (p) {
> +				while ((ch = *p++))
> +					putc(ch);
> +			}
>   		}
>   	}
>
>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

  reply	other threads:[~2015-12-29 13:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29 12:22 [U-Boot] [PATCH 00/10] rockchip: Tidy up SPL operation on jerry Simon Glass
2015-12-29 12:22 ` [U-Boot] [PATCH 01/10] rockchip: Enable generation of SPI images Simon Glass
2016-01-15  1:35   ` Simon Glass
2015-12-29 12:22 ` [U-Boot] [PATCH 02/10] rockchip: Drop a debug message when outputing " Simon Glass
2016-01-15  1:35   ` Simon Glass
2015-12-29 12:22 ` [U-Boot] [PATCH 03/10] rockchip: Fix the configuration for chromebook_jerry Simon Glass
2016-01-15  1:35   ` Simon Glass
2015-12-29 12:22 ` [U-Boot] [PATCH 04/10] tiny-printf: Avoid printing NULL strings Simon Glass
2015-12-29 13:23   ` Stefan Roese [this message]
2016-01-16  1:25     ` Simon Glass
2015-12-29 12:22 ` [U-Boot] [PATCH 05/10] dm: spi_flash: Allow the uclass to work without printf() Simon Glass
2016-01-15 13:22   ` Simon Glass
2015-12-29 12:22 ` [U-Boot] [PATCH 06/10] dm: gpio: " Simon Glass
2016-01-16  1:25   ` Simon Glass
2015-12-29 12:22 ` [U-Boot] [PATCH 07/10] dm: mmc: Try to honour the sequence order Simon Glass
2016-01-16  1:25   ` Simon Glass
2015-12-29 12:22 ` [U-Boot] [PATCH 08/10] i2c: Correct command return values Simon Glass
2016-01-04  7:08   ` Heiko Schocher
2016-01-16  1:25     ` Simon Glass
2015-12-29 12:22 ` [U-Boot] [PATCH 09/10] malloc_simple: Display an error when memory is exhausted Simon Glass
2015-12-29 12:22 ` [U-Boot] [PATCH 10/10] pinctrl: Avoid binding all pinconfig nodes before relocation Simon Glass
2016-01-16  1:26   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5682895D.20709@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.