All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Alexandru GOIA <alexandru.goia@cti.pub.ro>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 1/1] kernel booting messages, first line
Date: Tue, 29 Dec 2015 10:42:40 -0800	[thread overview]
Message-ID: <5682D420.3030207@infradead.org> (raw)
In-Reply-To: <DB5PR01MB10625F9B4570BCFBBD47FC52ACFC0@DB5PR01MB1062.eurprd01.prod.exchangelabs.com>

On 12/28/15 17:31, Alexandru GOIA wrote:
> 
> For -rc8 ,
> 
> Hoping that someone DO cares about the aesthetic of kernel messages at boot :
> 
>  
> What it does : first line of booting kernel, as seen in dmesg(1), will be the Linux kernel signature
> (version, compiler, compiler hostname).
> 
> What it solves : it appers ahead of cgroup messages at booting.
> 
> 
> This ugliness, since 3.10.x kernel.
> 
> 
> So :
> 
> Instead of the unaesthetic lines :
> 
> Initializing cgroup subsys cpuset
> Initializing cgroup subsys cpu
> Initializing cgroup subsys cpuacct
> Linux version 4 ...
> 
> 
> ... We will have :
> 
> 
> Linux version 4 ...
> Initializing cgroup subsys cpuset
> Initializing cgroup subsys cpu
> Initializing cgroup subsys cpuacct
> 
> 
> As normal .
> 
> 
> In file linux-4.4-rc7/init/main.c  :
> 
> <code>
> 
> --- main.c      2015-12-28 04:17:37.000000000 +0200
> +++ main+.c     2015-12-29 03:18:59.896820046 +0200
> @@ -512,6 +512,7 @@
>           * Set up the the initial canary ASAP:
>           */
>          boot_init_stack_canary();
> +       pr_notice("%s", linux_banner);
>  
>          cgroup_init_early();
>  
> @@ -524,7 +525,6 @@
>   */
>          boot_cpu_init();
>          page_address_init();
> -       pr_notice("%s", linux_banner);
>          setup_arch(&command_line);
>          mm_init_cpumask(&init_mm);
>          setup_command_line(command_line);
> 
> </code>
> 
> 
> Signed-off-by: Alexandru Goia <alexandru.goia@cti.pub.ro>--


I like the patch. Could you make it a proper kernel patch, please?


thanks,
-- 
~Randy

  reply	other threads:[~2015-12-29 18:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29  1:31 [PATCH 1/1] kernel booting messages, first line Alexandru GOIA
2015-12-29 18:42 ` Randy Dunlap [this message]
2015-12-29 19:24   ` Tejun Heo
     [not found]     ` <20151229192414.GB3873-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-12-29 19:57       ` [PATCH] cgroup: demote subsystem init messages to KERN_DEBUG Tejun Heo
2015-12-29 19:57         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5682D420.3030207@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=alexandru.goia@cti.pub.ro \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.