From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [PATCH 5/5] Allow all user to create a file under
 the directory /var/lib/xen
Date: Wed, 30 Dec 2015 13:25:30 +0800
Message-ID: <56836ACA.6070507@cn.fujitsu.com>
References: <1451439588-25310-1-git-send-email-wency@cn.fujitsu.com>
	<1451439588-25310-6-git-send-email-wency@cn.fujitsu.com>
	<5683597A.5090203@cardoe.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5683597A.5090203@cardoe.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Doug Goldstein <cardoe@cardoe.com>, xen devel <xen-devel@lists.xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Shriram Rajagopalan <rshriram@cs.ubc.ca>, Changlong Xie <xiecl.fnst@cn.fujitsu.com>, Yang Hongyang <hongyang.yang@easystack.cn>
List-Id: xen-devel@lists.xenproject.org

On 12/30/2015 12:11 PM, Doug Goldstein wrote:
> On 12/29/15 8:39 PM, Wen Congyang wrote:
>> We may use non-root user to run qemu, and the qemu needs to write
>> save file to /var/lib/xen. So we should allow all user to create
>> a file under the directory /var/lib/xen
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> ---
>>  tools/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/Makefile b/tools/Makefile
>> index 820ca40..402b417 100644
>> --- a/tools/Makefile
>> +++ b/tools/Makefile
>> @@ -60,7 +60,7 @@ build all: subdirs-all
>>  install: subdirs-install
>>  	$(INSTALL_DIR) -m 700 $(DESTDIR)$(XEN_DUMP_DIR)
>>  	$(INSTALL_DIR) $(DESTDIR)/var/log/xen
>> -	$(INSTALL_DIR) $(DESTDIR)/var/lib/xen
>> +	$(INSTALL_DIR) -m 777 $(DESTDIR)/var/lib/xen
>>  
>>  .PHONY: uninstall
>>  uninstall: D=$(DESTDIR)
>>
> 
> I could be wrong but this doesn't seem like something that you'd want to
> do given what's stored in there. Could you do something with permissions
> on sub-directories to achieve what you need?
> 

The save file's path is:
#define LIBXL_DEVICE_MODEL_SAVE_FILE "/var/lib/xen/qemu-save" /* .$domid */

So all user must have write permission on the directory /var/lib/xen/, otherwise,
the migration will fail.

Thanks
Wen Congyang