Re: [PATCH for-next V3 00/11] Add RoCE v2 support

[Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

On 12/30/2015 1:05 PM, Or Gerlitz wrote:
> On 12/30/2015 12:48 PM, Matan Barak wrote:
>>
>>
>> On 12/30/2015 8:04 AM, Or Gerlitz wrote:
>>> Hi Matan,
>>>
>>> I see these two smatch complaints on code added with this series, can
>>> you please take a look?
>>>
>>> drivers/infiniband/core/addr.c:503 rdma_resolve_ip_route() warn:
>>> variable dereferenced before check 'src_addr' (see line 500)
>>> drivers/infiniband/core/cma_configfs.c:172 make_cma_ports() warn: double
>>> check that we're allocating correct size: 8 vs 128
>>>
>>
>> I'll send fixes for both of them. Thanks for posting this.
>
> when the same smatch runs on older gcc, it produces more warnings, are
> they false-positives?
>
>

Yeah, false positives - cma_configfs_params_get returns 0 iff both 
cma_dev and group are valid.

>> drivers/infiniband/core/cma_configfs.c: In function
>> ?default_roce_mode_store?:
>> drivers/infiniband/core/cma_configfs.c:123: warning: ?cma_dev? may be
>> used uninitialized in this function
>> drivers/infiniband/core/cma_configfs.c:124: warning: ?group? may be
>> used uninitialized in this function
>> drivers/infiniband/core/cma_configfs.c: In function
>> ?default_roce_mode_show?:
>> drivers/infiniband/core/cma_configfs.c:102: warning: ?cma_dev? may be
>> used uninitialized in this function
>> drivers/infiniband/core/cma_configfs.c:103: warning: ?group? may be
>> used uninitialized in this function
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html