Re: chromium 40.0.2214.91 doesn't like gcc5.3

[Trevor Woerner <twoerner@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1813 bytes --]

Hi Khem,

On 12/30/15 13:04, Khem Raj wrote:
> can you backport and report back
>
> https://chromium.googlesource.com/v8/v8/+/e28183b5977a2d2732f7f8b9a2f26637c9566585%5E%21/#F0

That diff includes 4 patches:
    Index: src/bignum.cc
    Index: src/compiler/ia32/code-generator-ia32.cc
    Index: src/compiler/x64/code-generator-x64.cc
    Index: test/cctest/compiler/test-js-typed-lowering.cc

All of these patches only apply to the code in the "v8" folder.

The 4th one doesn't apply because I can't find a
"test-js-typed-lowering.cc" file anywhere in our version 40 sources.

Although the files "v8/src/compiler/ia32/code-generator-ia32.cc" and
"v8/src/compiler/x64/code-generator-x64.cc" exist, these two patches
don't apply since the code in those files doesn't look anything like
what these patches are trying to patch.

The first patch does apply, with the file path change (add v8 to the
front), and a 2 line offset.

For some reason this bignum.cc source is found in both v8/src and
third_party/WebKit/Source/wtf/dtoa and, apart from some extra namespace
scope, is very similar (if not the same). So I added a second patch to
this diff to also correctly patch the code in third_party/... .

Replacing Max's solution for this one does cause this one file to
compile fine, but other -Werror=strict-overflow problems are simply
found later (see attached).

Combining both Max's patch and this one causes this part of the build to
succeed, but still causes the -Werror=uninitialized problem to happen as
I reported earlier:

|
../../third_party/WebKit/Source/core/inspector/InspectorTimelineAgent.cpp:234:8:
error: '<anonymous>.blink::TimelineThreadState::inKnownLayerTask' is
used uninitialized in this function [-Werror=uninitialized]

Best regards,
    Trevor

[-- Attachment #2: strict-overflow.txt --]
[-- Type: text/plain, Size: 3274 bytes --]

| FAILED: x86_64-fortress-linux-g++  -m64 -march=corei7 -mtune=corei7 -mfpmath=sse -msse4.2 --sysroot=/z/layerindex-master/minnowmax/tmp/sysroots/intel-corei7-64 -MMD -MF obj/third_party/WebKit/Source/wtf/dtoa/wtf.bignum.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DDISABLE_NACL -DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DDONT_EMBED_BUILD_METADATA -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DWTF_IMPLEMENTATION=1 -DENABLE_OPENTYPE_VERTICAL=1 -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DENABLE_WEB_AUDIO=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../../third_party/WebKit/Source -I../../third_party/WebKit -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -B/z/layerindex-master/minnowmax/tmp/work/corei7-64-fortress-linux/chromium/40.0.2214.91-r0/chromium-40.0.2214.91/third_party/binutils/Linux_x64/Release/bin -Wno-unused-local-typedefs -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables -Wno-error=unused-local-typedefs -O2 -pipe -g -feliminate-unused-debug-types -fvisibility-inlines-hidden -Wno-c++0x-compat -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-c++0x-compat -std=gnu++11 -Wno-narrowing -Wno-literal-suffix  -c ../../third_party/WebKit/Source/wtf/dtoa/bignum.cc -o obj/third_party/WebKit/Source/wtf/dtoa/wtf.bignum.o
| ../../third_party/WebKit/Source/wtf/dtoa/bignum.cc: In member function 'void WTF::double_conversion::Bignum::Align(const WTF::double_conversion::Bignum&)':
| ../../third_party/WebKit/Source/wtf/dtoa/bignum.cc:717:31: error: assuming signed overflow does not occur when simplifying conditional to constant [-Werror=strict-overflow]
|              for (int i = 0; i < zero_digits; ++i) {
|                                ^
| ../../third_party/WebKit/Source/wtf/dtoa/bignum.cc:717:31: error: assuming signed overflow does not occur when simplifying conditional to constant [-Werror=strict-overflow]