From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kannan, Vandana" Subject: Re: [PATCH] drm/i915/bxt: Fix eDP panel power save/restore Date: Thu, 31 Dec 2015 08:31:45 +0530 Message-ID: <56849A99.1070406@intel.com> References: <1451516190-28723-1-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1451516190-28723-1-git-send-email-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper , intel-gfx@lists.freedesktop.org, Jani Nikula Cc: drm-intel-fixes@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org V2hlbiBJIHN1Ym1pdHRlZCB0aGUgUFBTIHBhdGNoIGluIEFwcmlsLCBJIGdvdCBhbiBpbnB1dCBm cm9tIEphbmkgdG8gbm90IAptYWtlIGNoYW5nZXMgaW4gaTkxNV9zdXNwZW5kLmMgYXMgaXQgd2Fz IHRvIGJlY29tZSBvYnNvbGV0ZS4gQmVsb3cgbWFpbCAKZm9yIHlvdXIgcmVmZXJlbmNlLgoKSmFu aSwKRG9lcyB5b3VyIGluaXRpYWwgY29tbWVudCBzdGlsbCBob2xkIGdvb2Q/CgpPbiBUaHUsIDMw IEFwciAyMDE1LCBWYW5kYW5hIEthbm5hbiA8dmFuZGFuYS5rYW5uYW5AaW50ZWwuY29tPiB3cm90 ZToKID4gQ2hhbmdlcyBiYXNlZCBvbiBmdXR1cmUgcGxhdGZvcm0gcmVhZGluZXNzIHBhdGNoZXMg cmVsYXRlZCB0bwogPiBIQVNfUENIX1NQTElUKCkuIFVzZSBIQVNfR01DSF9ESVNQTEFZKCkgaW5z dGVhZCBvZiBIQVNfUENIX1NQTElUCiA+CiA+IFNpZ25lZC1vZmYtYnk6IFZhbmRhbmEgS2FubmFu IDx2YW5kYW5hLmthbm5hbkBpbnRlbC5jb20+CiA+IFNpZ25lZC1vZmYtYnk6IEEuU3VuaWwgS2Ft YXRoIDxzdW5pbC5rYW1hdGhAaW50ZWwuY29tPgogPiAtLS0KID4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfc3VzcGVuZC5jIHwgNCArKy0tCiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcC5jICAgICB8IDggKysrKy0tLS0KID4gIDIgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25z KCspLCA2IGRlbGV0aW9ucygtKQogPgogPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9zdXNwZW5kLmMKID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3N1c3BlbmQu YwogPiBpbmRleCBjZjY3ZjgyLi5lOTFkNjM3IDEwMDY0NAogPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3N1c3BlbmQuYwogPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3N1c3BlbmQuYwogPiBAQCAtNDQsNyArNDQsNyBAQCBzdGF0aWMgdm9pZCBpOTE1X3NhdmVfZGlz cGxheShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQogPiAgCQlkZXZfcHJpdi0+cmVnZmlsZS5zYXZl TFZEUyA9IEk5MTVfUkVBRChMVkRTKTsKID4KID4gIAkvKiBQYW5lbCBwb3dlciBzZXF1ZW5jZXIg Ki8KID4gLQlpZiAoSEFTX1BDSF9TUExJVChkZXYpKSB7CiA+ICsJaWYgKCFIQVNfR01DSF9ESVNQ TEFZKGRldikpIHsKID4gIAkJZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQX0NPTlRST0wgPSBJOTE1 X1JFQUQoUENIX1BQX0NPTlRST0wpOwogPiAgCQlkZXZfcHJpdi0+cmVnZmlsZS5zYXZlUFBfT05f REVMQVlTID0gSTkxNV9SRUFEKFBDSF9QUF9PTl9ERUxBWVMpOwogPiAgCQlkZXZfcHJpdi0+cmVn ZmlsZS5zYXZlUFBfT0ZGX0RFTEFZUyA9IEk5MTVfUkVBRChQQ0hfUFBfT0ZGX0RFTEFZUyk7CiA+ IEBAIC03OSw3ICs3OSw3IEBAIHN0YXRpYyB2b2lkIGk5MTVfcmVzdG9yZV9kaXNwbGF5KHN0cnVj dCBkcm1fZGV2aWNlIAoqZGV2KQogPiAgCQlJOTE1X1dSSVRFKExWRFMsIGRldl9wcml2LT5yZWdm aWxlLnNhdmVMVkRTICYgbWFzayk7CiA+CiA+ICAJLyogUGFuZWwgcG93ZXIgc2VxdWVuY2VyICov CiA+IC0JaWYgKEhBU19QQ0hfU1BMSVQoZGV2KSkgewogPiArCWlmICghSEFTX0dNQ0hfRElTUExB WShkZXYpKSB7CiA+ICAJCUk5MTVfV1JJVEUoUENIX1BQX09OX0RFTEFZUywgZGV2X3ByaXYtPnJl Z2ZpbGUuc2F2ZVBQX09OX0RFTEFZUyk7CiA+ICAJCUk5MTVfV1JJVEUoUENIX1BQX09GRl9ERUxB WVMsIGRldl9wcml2LT5yZWdmaWxlLnNhdmVQUF9PRkZfREVMQVlTKTsKID4gIAkJSTkxNV9XUklU RShQQ0hfUFBfRElWSVNPUiwgZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQX0RJVklTT1IpOwoKSSBk b24ndCB0aGluayB5b3Ugc2hvdWxkIHRvdWNoIGk5MTVfc3VzcGVuZC5jIGF0IGFsbC4gV2UncmUg dHJ5aW5nIHRvIApnZXQgcmlkIG9mIHRoaXMgYmxpbmQgcmVnaXN0ZXIgc2F2ZS9yZXN0b3JlLCBh bmQgbWFrZSBldmVyeXRoaW5nIHdvcmsgaW4gCnRoZSBlbmNvZGVyL2Nvbm5lY3RvciBjb2RlLiBE byBub3RlIHRoYXQgd2UgYWxyZWFkeSBza2lwIHRoaXMgZm9yIAp2bHYvY2h2IHBvd2VyIHNlcXVl bmNlciByZWdpc3RlcnMuCgogPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHAuYwogPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgaW5kZXggOTM3YmEz MS4uNjhlMTBjMSAxMDA2NDQKID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAu YwogPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCiA+IEBAIC01NTksNyAr NTU5LDcgQEAgc3RhdGljIHUzMiBfcHBfY3RybF9yZWcoc3RydWN0IGludGVsX2RwICppbnRlbF9k cCkKID4gewogPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9kcF90b19kZXYoaW50 ZWxfZHApOwogPgogPiAtCWlmIChIQVNfUENIX1NQTElUKGRldikpCiA+ICsJaWYgKCFIQVNfR01D SF9ESVNQTEFZKGRldikpCiA+ICAJCXJldHVybiBQQ0hfUFBfQ09OVFJPTDsKID4gIAllbHNlCiA+ ICAJCXJldHVybiBWTFZfUElQRV9QUF9DT05UUk9MKHZsdl9wb3dlcl9zZXF1ZW5jZXJfcGlwZShp bnRlbF9kcCkpOwogPiBAQCAtNTY5LDcgKzU2OSw3IEBAIHN0YXRpYyB1MzIgX3BwX3N0YXRfcmVn KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCiA+IHsKID4gIAlzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2ID0gaW50ZWxfZHBfdG9fZGV2KGludGVsX2RwKTsKID4KID4gLQlpZiAoSEFTX1BDSF9TUExJ VChkZXYpKQogPiArCWlmICghSEFTX0dNQ0hfRElTUExBWShkZXYpKQogPiAgCQlyZXR1cm4gUENI X1BQX1NUQVRVUzsKID4gIAllbHNlCiA+ICAJCXJldHVybiBWTFZfUElQRV9QUF9TVEFUVVModmx2 X3Bvd2VyX3NlcXVlbmNlcl9waXBlKGludGVsX2RwKSk7CiA+IEBAIC00OTYzLDcgKzQ5NjMsNyBA QCBpbnRlbF9kcF9pbml0X3BhbmVsX3Bvd2VyX3NlcXVlbmNlcihzdHJ1Y3QgCmRybV9kZXZpY2Ug KmRldiwKID4gIAlpZiAoZmluYWwtPnQxMV90MTIgIT0gMCkKID4gIAkJcmV0dXJuOwogPgogPiAt CWlmIChIQVNfUENIX1NQTElUKGRldikpIHsKID4gKwlpZiAoIUhBU19HTUNIX0RJU1BMQVkoZGV2 KSkgewogPiAgCQlwcF9jdHJsX3JlZyA9IFBDSF9QUF9DT05UUk9MOwogPiAgCQlwcF9vbl9yZWcg PSBQQ0hfUFBfT05fREVMQVlTOwogPiAgCQlwcF9vZmZfcmVnID0gUENIX1BQX09GRl9ERUxBWVM7 CiA+IEBAIC01MDYzLDcgKzUwNjMsNyBAQAogPiBpbnRlbF9kcF9pbml0X3BhbmVsX3Bvd2VyX3Nl cXVlbmNlcl9yZWdpc3RlcnMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKID4KID4gIAlsb2NrZGVw X2Fzc2VydF9oZWxkKCZkZXZfcHJpdi0+cHBzX211dGV4KTsKID4KID4gLQlpZiAoSEFTX1BDSF9T UExJVChkZXYpKSB7CiA+ICsJaWYgKCFIQVNfR01DSF9ESVNQTEFZKGRldikpIHsKID4gIAkJcHBf b25fcmVnID0gUENIX1BQX09OX0RFTEFZUzsKID4gIAkJcHBfb2ZmX3JlZyA9IFBDSF9QUF9PRkZf REVMQVlTOwogPiAgCQlwcF9kaXZfcmVnID0gUENIX1BQX0RJVklTT1I7CgpGb3IgdGhlIHJlc3Qs IEknZCBsaWtlIHlvdSB0byBkbyB3aGF0IEkgc3VnZ2VzdGVkIGluIG15IHJlcGx5IHRvIHBhdGNo IAozLCBpLmUuIGFkZCBhIG5ldyBpZiAoSVNfQlJPWFRPTihkZXYpKSBhdCB0aGUgdG9wIG9mIGVh Y2ggb2YgdGhlc2UsIHdpdGgKQlhUX1BQX1dIQVRFVkVSKDApIGFzIHRoZSByZWdpc3Rlci4gTGF0 ZXIgb24sIHdlIGNhbiBhZGQgY29kZSB0byBjaG9vc2UgCnRoZSBwb3dlciBzZXF1ZW5jZXIsIGEg Yml0IHNpbWlsYXIgdG8gd2hhdCB2bHYvY2h2IGRvIG5vdyAoZXhjZXB0IHRoZXJlIAppdCdzIGJh c2VkIG9uIHBpcGUpLgoKQlIsCkphbmkuCgogPiAtLQogPiAyLjAuMQogPgogPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwogPiBJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKID4gaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0KSmFuaSBOaWt1 bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCgotIFZhbmRhbmEKCgpPbiAx Mi8zMS8yMDE1IDQ6MjYgQU0sIE1hdHQgUm9wZXIgd3JvdGU6Cj4gQnJveHRvbi1zcGVjaWZpYyBw YW5lbCBwb3dlciBzZXF1ZW5jaW5nIHdhcyBhZGRlZCBpbiBjb21taXQKPgo+ICAgICAgICAgIGNv bW1pdCBiMGEwOGJlYzk2MzE4YmU1NGRiOTdjM2YwYjllMzdiNTI1NjFmOWVhCj4gICAgICAgICAg QXV0aG9yOiBWYW5kYW5hIEthbm5hbiA8dmFuZGFuYS5rYW5uYW5AaW50ZWwuY29tPgo+ICAgICAg ICAgIERhdGU6ICAgVGh1IEp1biAxOCAxMTowMDo1NSAyMDE1ICswNTMwCj4KPiAgICAgICAgICAg ICAgZHJtL2k5MTUvYnh0OiBlRFAgUGFuZWwgUG93ZXIgc2VxdWVuY2luZwo+Cj4gQXMgbm90ZWQg aW4gdGhhdCBjb21taXQsIEJyb3h0b24gaGFzIHR3byBzZXRzIG9mIHJlZ2lzdGVycyAoYW5kIHdl J3JlCj4gc3VwcG9zZWQgdG8gcmVhZCB3aGljaCB0byB1c2UgZnJvbSB0aGUgVkJULCBhbHRob3Vn aCB3ZSdyZSBwdW50aW5nIG9uCj4gdGhhdCBwYXJ0IGF0IHRoZSBtb21lbnQpIGFuZCBhbHNvIGRv ZXNuJ3QgaGF2ZSBhIGRpdmlzb3IgcmVnaXN0ZXIuCj4gQWx0aG91Z2ggd2UgdGFrZSB0aGUgQlhU LXNwZWNpZmljIGRldGFpbHMgaW50byBhY2NvdW50IGF0IGluaXRpYWwgc3lzdGVtCj4gaW5pdCwg d2UgZmFpbCB0byBzYXZlL3Jlc3RvcmUgdGhlIGFwcHJvcHJpYXRlIHJlZ2lzdGVycyBhcm91bmQg c3lzdGVtCj4gc3VzcGVuZC9yZXN1bWUsIHdoaWNoIGxlYWRzIHRvIHVuY2xhaW1lZCByZWdpc3Rl ciB3YXJuaW5ncyBhdCB0aGUKPiBtb21lbnQsIGFuZCBtYXkgYWxzbyBmYWlsIHRvIHNhdmUgdGhl IHByb3BlciByZWdpc3RlcnMgb25jZSB3ZSBzdGFydAo+IGFjdHVhbGx5IHBheWluZyBhdHRlbnRp b24gdG8gdGhlIFZCVC4KPgo+IENjOiBWYW5kYW5hIEthbm5hbiA8dmFuZGFuYS5rYW5uYW5AaW50 ZWwuY29tPgo+IENjOiBkcm0taW50ZWwtZml4ZXNAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gU2ln bmVkLW9mZi1ieTogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiAtLS0K PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3VzcGVuZC5jIHwgMjQgKysrKysrKysrKysr KysrKysrKysrKy0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3N1c3Bl bmQuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3VzcGVuZC5jCj4gaW5kZXggYmY1ODJm ZS4uNjFiZWM4ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3N1c3Bl bmQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3VzcGVuZC5jCj4gQEAgLTQ0 LDcgKzQ0LDE4IEBAIHN0YXRpYyB2b2lkIGk5MTVfc2F2ZV9kaXNwbGF5KHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpCj4gICAJCWRldl9wcml2LT5yZWdmaWxlLnNhdmVMVkRTID0gSTkxNV9SRUFEKExW RFMpOwo+Cj4gICAJLyogUGFuZWwgcG93ZXIgc2VxdWVuY2VyICovCj4gLQlpZiAoSEFTX1BDSF9T UExJVChkZXYpKSB7Cj4gKwlpZiAoSVNfQlJPWFRPTihkZXYpKSB7Cj4gKwkJLyoKPiArCQkgKiBU T0RPOiBCWFQgaGFzIDIgc2V0cyBvZiBQUFMgcmVnaXN0ZXJzLgo+ICsJCSAqIENvcnJlY3QgUmVn aXN0ZXIgZm9yIEJyb3h0b24gbmVlZCB0byBiZSBpZGVudGlmaWVkCj4gKwkJICogdXNpbmcgVkJU LiBoYXJkY29kaW5nIGZvciBub3cuCj4gKwkJICoKPiArCQkgKiBUaGVyZSdzIGFsc28gbm8gZGl2 aXNvciByZWdpc3RlciBvbiBCcm94dG9uLgo+ICsJCSAqLwo+ICsJCWRldl9wcml2LT5yZWdmaWxl LnNhdmVQUF9DT05UUk9MID0gSTkxNV9SRUFEKEJYVF9QUF9DT05UUk9MKDApKTsKPiArCQlkZXZf cHJpdi0+cmVnZmlsZS5zYXZlUFBfT05fREVMQVlTID0gSTkxNV9SRUFEKEJYVF9QUF9PTl9ERUxB WVMoMCkpOwo+ICsJCWRldl9wcml2LT5yZWdmaWxlLnNhdmVQUF9PRkZfREVMQVlTID0gSTkxNV9S RUFEKEJYVF9QUF9PRkZfREVMQVlTKDApKTsKPiArCX0gZWxzZSBpZiAoSEFTX1BDSF9TUExJVChk ZXYpKSB7Cj4gICAJCWRldl9wcml2LT5yZWdmaWxlLnNhdmVQUF9DT05UUk9MID0gSTkxNV9SRUFE KFBDSF9QUF9DT05UUk9MKTsKPiAgIAkJZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQX09OX0RFTEFZ UyA9IEk5MTVfUkVBRChQQ0hfUFBfT05fREVMQVlTKTsKPiAgIAkJZGV2X3ByaXYtPnJlZ2ZpbGUu c2F2ZVBQX09GRl9ERUxBWVMgPSBJOTE1X1JFQUQoUENIX1BQX09GRl9ERUxBWVMpOwo+IEBAIC04 Myw3ICs5NCwxNiBAQCBzdGF0aWMgdm9pZCBpOTE1X3Jlc3RvcmVfZGlzcGxheShzdHJ1Y3QgZHJt X2RldmljZSAqZGV2KQo+ICAgCQlJOTE1X1dSSVRFKExWRFMsIGRldl9wcml2LT5yZWdmaWxlLnNh dmVMVkRTICYgbWFzayk7Cj4KPiAgIAkvKiBQYW5lbCBwb3dlciBzZXF1ZW5jZXIgKi8KPiAtCWlm IChIQVNfUENIX1NQTElUKGRldikpIHsKPiArCWlmIChJU19CUk9YVE9OKGRldikpIHsKPiArCQkv Kgo+ICsJCSAqIFRPRE86IEJYVCBoYXMgMiBzZXRzIG9mIFBQUyByZWdpc3RlcnMuCj4gKwkJICog Q29ycmVjdCBSZWdpc3RlciBmb3IgQnJveHRvbiBuZWVkIHRvIGJlIGlkZW50aWZpZWQKPiArCQkg KiB1c2luZyBWQlQuIGhhcmRjb2RpbmcgZm9yIG5vdwo+ICsJCSAqLwo+ICsJCUk5MTVfV1JJVEUo QlhUX1BQX09OX0RFTEFZUygwKSwgZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQX09OX0RFTEFZUyk7 Cj4gKwkJSTkxNV9XUklURShCWFRfUFBfT0ZGX0RFTEFZUygwKSwgZGV2X3ByaXYtPnJlZ2ZpbGUu c2F2ZVBQX09GRl9ERUxBWVMpOwo+ICsJCUk5MTVfV1JJVEUoQlhUX1BQX0NPTlRST0woMCksIGRl dl9wcml2LT5yZWdmaWxlLnNhdmVQUF9DT05UUk9MKTsKPiArCX0gZWxzZSBpZiAoSEFTX1BDSF9T UExJVChkZXYpKSB7Cj4gICAJCUk5MTVfV1JJVEUoUENIX1BQX09OX0RFTEFZUywgZGV2X3ByaXYt PnJlZ2ZpbGUuc2F2ZVBQX09OX0RFTEFZUyk7Cj4gICAJCUk5MTVfV1JJVEUoUENIX1BQX09GRl9E RUxBWVMsIGRldl9wcml2LT5yZWdmaWxlLnNhdmVQUF9PRkZfREVMQVlTKTsKPiAgIAkJSTkxNV9X UklURShQQ0hfUFBfRElWSVNPUiwgZGV2X3ByaXYtPnJlZ2ZpbGUuc2F2ZVBQX0RJVklTT1IpOwo+ Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==