From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH for-next 5/7] IB/mlx4: Enable send of RoCE QP1 packets with IP/UDP headers Date: Thu, 31 Dec 2015 09:04:05 +0200 Message-ID: <5684D365.1010607@mellanox.com> References: <1451395447-5198-1-git-send-email-matanb@mellanox.com> <1451395447-5198-6-git-send-email-matanb@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Moni Shoua , Or Gerlitz Cc: Matan Barak , Doug Ledford , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Yishai Hadas , Majd Dibbiny List-Id: linux-rdma@vger.kernel.org On 12/30/2015 1:04 PM, Moni Shoua wrote: >> The last hunk that you removed had a role and was by no means >> dead-code, right? so... (1) why it's correct to remove it? (2) if you >> want to introduce different way to implement what was done here, why >> in this patch? maybe add pre-patch for that > In a way you are right. This hunk does not insert a bug and even > improves correctness but it acutally belongs to an earlier patch > (dbf727de7440f73c4b92be4b958cbc24977e8ca2 IB/core: Use GID table in AH > creation and dmac resolution) so what's the plan here? avoid deleting it? Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html