All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH 1/3] irq_poll: Fix irq_poll_sched()
Date: Thu, 31 Dec 2015 09:56:03 +0100	[thread overview]
Message-ID: <5684EDA3.60802@sandisk.com> (raw)
In-Reply-To: <5684ED4B.2010303-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>

The IRQ_POLL_F_SCHED bit is set as long as polling is ongoing.
This means that irq_poll_sched() must proceed if this bit has
not yet been set.

Fixes: commit ea51190c0315 ("irq_poll: fold irq_poll_sched_prep into irq_poll_sched").
Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
 lib/irq_poll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/irq_poll.c b/lib/irq_poll.c
index 2836620..836f7db 100644
--- a/lib/irq_poll.c
+++ b/lib/irq_poll.c
@@ -29,7 +29,7 @@ void irq_poll_sched(struct irq_poll *iop)
 
 	if (test_bit(IRQ_POLL_F_DISABLE, &iop->state))
 		return;
-	if (!test_and_set_bit(IRQ_POLL_F_SCHED, &iop->state))
+	if (test_and_set_bit(IRQ_POLL_F_SCHED, &iop->state))
 		return;
 
 	local_irq_save(flags);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-12-31  8:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-31  8:54 [PATCH 0/3] Three SRP driver patches for kernel 4.5 Bart Van Assche
     [not found] ` <5684ED4B.2010303-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-12-31  8:56   ` Bart Van Assche [this message]
     [not found]     ` <5684EDA3.60802-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-03 11:15       ` [PATCH 1/3] irq_poll: Fix irq_poll_sched() Sagi Grimberg
2015-12-31  8:56   ` [PATCH 2/3] IB/srpt: Fix the RDMA completion handlers Bart Van Assche
     [not found]     ` <5684EDCB.30606-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-03 11:16       ` Sagi Grimberg
2015-12-31  8:57   ` [PATCH 3/3] IB/srpt: Fix a race condition related to SRP login Bart Van Assche
     [not found]     ` <5684EE16.8070701-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-03 10:51       ` Christoph Hellwig
     [not found]         ` <20160103105127.GA10025-jcswGhMUV9g@public.gmane.org>
2016-01-03 11:24           ` Sagi Grimberg
     [not found]             ` <56890507.9080404-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-01-03 13:01               ` Bart Van Assche
     [not found]                 ` <56891BB8.6040502-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-03 13:09                   ` Sagi Grimberg
     [not found]                     ` <56891DA5.5060506-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-01-15 22:14                       ` Bart Van Assche
2016-01-19 20:43   ` [PATCH 0/3] Three SRP driver patches for kernel 4.5 Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5684EDA3.60802@sandisk.com \
    --to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.