From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aEciz-0005y3-MJ for mharc-grub-devel@gnu.org; Thu, 31 Dec 2015 07:53:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aEciv-0005wY-9S for grub-devel@gnu.org; Thu, 31 Dec 2015 07:52:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aEciu-0001iS-Ax for grub-devel@gnu.org; Thu, 31 Dec 2015 07:52:57 -0500 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:37220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aEciu-0001iN-4P for grub-devel@gnu.org; Thu, 31 Dec 2015 07:52:56 -0500 Received: by mail-wm0-x231.google.com with SMTP id f206so110786672wmf.0 for ; Thu, 31 Dec 2015 04:52:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type; bh=NcoliOfxM7BJogOVhVE4edU+d/TKtG83G+Izw+E6Pvo=; b=a97QgexnJzNd9eoIArvETKUSIgxV3y/tSaYwqWAClHM50FEYqNZdOpzKcEA2ylUYsa uk7cOts9IfPDg9sdAtyrbO4H0v2IovQVjbKnVpzsBOK2ItHxs04/JbZBR+E6ihmGEsV3 ZlJv7BdEeMt8v1PN5AjNiOBwKAydKzAMNnHpce9leKAubTNJKMnd32/vQ8R0mz+RfiIv bfTfoFtFvhDYE0CzvwjlQrfB/x3dxT+k74KJE1bhaDYt0Jjs+bDqr5L0seWuZ19MRmOL 68f0JXQNn4zKXy4Z7haOakO3GKzy4zRIeAHA1r4PqIxEAa3Q562Pm+tAuItt8KZZazzf SDYQ== X-Received: by 10.28.178.206 with SMTP id b197mr74174795wmf.20.1451566375287; Thu, 31 Dec 2015 04:52:55 -0800 (PST) Received: from ?IPv6:2a02:120b:2c2b:b80:a2a8:cdff:fe64:b3b5? ([2a02:120b:2c2b:b80:a2a8:cdff:fe64:b3b5]) by smtp.gmail.com with ESMTPSA id 79sm23253433wmo.7.2015.12.31.04.52.53 for (version=TLSv1/SSLv3 cipher=OTHER); Thu, 31 Dec 2015 04:52:53 -0800 (PST) Subject: Re: [PATCH] arm64: build with -mcmodel=large To: grub-devel@gnu.org References: <20151224041420.GA26276@riva.ucam.org> <20151224042029.GC26276@riva.ucam.org> <20151225181855.GU25034@bivouac.eciton.net> From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Message-ID: <5685251C.4000600@gmail.com> Date: Thu, 31 Dec 2015 13:52:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151225181855.GU25034@bivouac.eciton.net> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IpskMibtQWeP0eR0OfTTBcUe90WkoF5M1" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::231 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Dec 2015 12:52:59 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IpskMibtQWeP0eR0OfTTBcUe90WkoF5M1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 25.12.2015 19:18, Leif Lindholm wrote: > On Thu, Dec 24, 2015 at 04:20:29AM +0000, Colin Watson wrote: >> On Thu, Dec 24, 2015 at 04:14:20AM +0000, Colin Watson wrote: >>> This fixes a build failure with very current GCC versions, such as th= e one >>> in Ubuntu xenial. Leif (or anyone with suitable arm64 systems), woul= d you >>> mind testing that this doesn't break things? I've tested that it bui= lds >>> cleanly now, but I don't have a particularly convenient way to do any= >>> run-time tests. >> >> Never mind, I spoke too soon and withdraw this patch, since this doesn= 't >> actually fix the problem, which is: >> >> $ obj/grub-efi-arm64/grub-mkimage -O arm64-efi -o test.efi -d obj/gr= ub-efi-arm64/grub-core -p /boot/grub -v ext2 >> obj/grub-efi-arm64/grub-mkimage: info: the total module size is 0x37= e8. >=20 > *snip* >=20 >> obj/grub-efi-arm64/grub-mkimage: info: dealing with the relocation s= ection .rela.text for .text. >> obj/grub-efi-arm64/grub-mkimage: error: relocation 0x113 is not impl= emented yet. >> >> Would anyone arm64-knowledgeable mind taking a look at this? >=20 > So, it seems this toolchain generates the HI21/LO12 relocation combo: > - R_AARCH64_ADR_PREL_PG_HI21/R_AARCH64_ADR_PREL_PG_HI21_NC > - R_AARCH64_LDST16_ABS_LO12_NC > - R_AARCH64_LDST32_ABS_LO12_NC > - R_AARCH64_LDST64_ABS_LO12_NC > - R_AARCH64_LDST128_ABS_LO12_NC >=20 > So I'll implement support for these. >=20 I'm looking forward for those patches Unfortunately missing relocation support is common problem. I added a verifier in build system to catch it on build time rather than runtime > With regards to your -mcmodel=3Dlarge patch - that didn't change > anything because I already hardcoded that into > conf/Makefile.common. Your suggested patch is probably the better way > of doing it - so do consider pushing that anyway (dropping the > Makefile.common stanza at the same time). >=20 > / > Leif >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --IpskMibtQWeP0eR0OfTTBcUe90WkoF5M1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlaFJSUACgkQmBXlbbo5nOufaQD/eFRa0VjnF2lJt9vphGJI9fRc ZxT16CsxOUyMSJcs7cQA/Am6VSx/WoBmxcM9LkRu1Zy1PKRTJedRlAeYi2NZQcZy =MxKp -----END PGP SIGNATURE----- --IpskMibtQWeP0eR0OfTTBcUe90WkoF5M1--