From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <jbottomley@odin.com>,
Ewan Milne <emilne@redhat.com>,
Bart van Assche <bart.vanassche@sandisk.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 08/20] scsi_dh_alua: use unique device id
Date: Thu, 31 Dec 2015 13:53:47 +0100 [thread overview]
Message-ID: <5685255B.2070101@suse.de> (raw)
In-Reply-To: <20151230112024.GB14156@lst.de>
On 12/30/2015 12:20 PM, Christoph Hellwig wrote:
> On Tue, Dec 08, 2015 at 08:37:28AM +0100, Hannes Reinecke wrote:
>> Use scsi_vpd_lun_id() to assign a unique device identification
>> to the alua port group structure.
>
> I really hate the fix length arrays and how they are passed around.
>
You and me both.
I would love to be able to identify port group states by a simple 64bit
identifier, but SCSI Names throws everything into disarray,
> Can't you move the call to scsi_vpd_lun_id into alua_get_pg (alua_alloc_pg)?
>
Hmm. Think so, yes,
> Also I think the new alua_lookup_pg should be alua_find_get_pg or
> similar as it takes a reference on the pg.
>
Sure, no problem with that,
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-31 12:53 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 7:37 [PATCH 00/20] ALUA device handler update, part II Hannes Reinecke
2015-12-08 7:37 ` [PATCH 01/20] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2015-12-08 7:37 ` [PATCH 02/20] scsi_dh_alua: separate out alua_stpg() Hannes Reinecke
2015-12-30 11:06 ` Christoph Hellwig
2015-12-08 7:37 ` [PATCH 03/20] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2015-12-30 11:10 ` Christoph Hellwig
2015-12-08 7:37 ` [PATCH 04/20] scsi_dh_alua: call alua_rtpg() if stpg fails Hannes Reinecke
2015-12-30 11:10 ` Christoph Hellwig
2015-12-08 7:37 ` [PATCH 05/20] scsi_dh_alua: switch to scsi_execute_req_flags() Hannes Reinecke
2015-12-08 7:37 ` [PATCH 06/20] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2015-12-30 11:17 ` Christoph Hellwig
2015-12-31 12:47 ` Hannes Reinecke
2015-12-08 7:37 ` [PATCH 07/20] scsi_dh_alua: allocate RTPG buffer separately Hannes Reinecke
2015-12-08 7:37 ` [PATCH 08/20] scsi_dh_alua: use unique device id Hannes Reinecke
2015-12-30 11:20 ` Christoph Hellwig
2015-12-31 12:53 ` Hannes Reinecke [this message]
2015-12-08 7:37 ` [PATCH 09/20] scsi_dh_alua: simplify alua_initialize() Hannes Reinecke
2015-12-30 11:21 ` Christoph Hellwig
2015-12-08 7:37 ` [PATCH 10/20] revert commit a8e5a2d593cb ("[SCSI] scsi_dh_alua: ALUA handler attach should succeed while TPG is transitioning") Hannes Reinecke
2015-12-30 11:22 ` Christoph Hellwig
2015-12-31 12:54 ` Hannes Reinecke
2015-12-08 7:37 ` [PATCH 11/20] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2015-12-30 13:19 ` Christoph Hellwig
2015-12-31 13:01 ` Hannes Reinecke
2016-01-03 10:53 ` Christoph Hellwig
2015-12-08 7:37 ` [PATCH 12/20] scsi_dh_alua: Allow workqueue to run synchronously Hannes Reinecke
2015-12-30 13:20 ` Christoph Hellwig
2015-12-31 13:54 ` Hannes Reinecke
2016-01-03 10:54 ` Christoph Hellwig
2015-12-08 7:37 ` [PATCH 13/20] scsi_dh_alua: Recheck state on unit attention Hannes Reinecke
2015-12-30 13:22 ` Christoph Hellwig
2015-12-31 14:02 ` Hannes Reinecke
2015-12-08 7:37 ` [PATCH 14/20] scsi_dh_alua: update all port states Hannes Reinecke
2015-12-30 13:23 ` Christoph Hellwig
2015-12-31 14:09 ` Hannes Reinecke
2015-12-08 7:37 ` [PATCH 15/20] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning Hannes Reinecke
2015-12-30 13:24 ` Christoph Hellwig
2015-12-08 7:37 ` [PATCH 16/20] scsi_dh: add 'rescan' callback Hannes Reinecke
2015-12-30 13:24 ` Christoph Hellwig
2015-12-08 7:37 ` [PATCH 17/20] scsi: Add 'access_state' attribute Hannes Reinecke
2015-12-30 13:24 ` Christoph Hellwig
2015-12-30 13:26 ` Christoph Hellwig
2015-12-08 7:37 ` [PATCH 18/20] scsi_dh_alua: use common definitions for ALUA state Hannes Reinecke
2015-12-30 13:28 ` Christoph Hellwig
2015-12-08 7:37 ` [PATCH 19/20] scsi_dh_alua: update 'access_state' field Hannes Reinecke
2015-12-30 13:34 ` Christoph Hellwig
2015-12-31 14:15 ` Hannes Reinecke
2015-12-08 7:37 ` [PATCH 20/20] scsi_dh_alua: Update version to 2.0 Hannes Reinecke
2015-12-08 15:06 ` [PATCH 00/20] ALUA device handler update, part II Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5685255B.2070101@suse.de \
--to=hare@suse.de \
--cc=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=jbottomley@odin.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.