From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [RFC PATCH] thermal: Schedule a backup thermal shutdown workqueue after a known period of time to tackle failed poweroff Date: Thu, 31 Dec 2015 12:29:58 -0600 Message-ID: <56857426.7000701@ti.com> References: <1450676778-7840-1-git-send-email-j-keerthy@ti.com> <5681742C.8050805@ti.com> <56824F81.7000202@ti.com> <20151231172906.GB11863@localhost.localdomain> <56856A4D.7090804@ti.com> <20151231182016.GA14127@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151231182016.GA14127@localhost.localdomain> Sender: linux-pm-owner@vger.kernel.org To: Eduardo Valentin Cc: Keerthy , Keerthy , rui.zhang@intel.com, linux-omap@vger.kernel.org, "linux-pm@vger.kernel.org" List-Id: linux-omap@vger.kernel.org On 12/31/2015 12:20 PM, Eduardo Valentin wrote: > On Thu, Dec 31, 2015 at 11:47:57AM -0600, Nishanth Menon wrote: >> On 12/31/2015 11:29 AM, Eduardo Valentin wrote: >>> can we have a shorter title? >>> >>> >>> Orderly power off is supposed to take care of this. Looking at the code, >>> it will force a shutdown in case execution of userland command fails: >>> >>> static int __orderly_poweroff(bool force) >>> { >>> int ret; >>> >>> ret = run_cmd(poweroff_cmd); >>> >>> if (ret && force) { >>> pr_warn("Failed to start orderly shutdown: forcing the issue\n"); >>> >>> /* >>> * I guess this should try to kick off some daemon to sync and >>> * poweroff asap. Or not even bother syncing if we're doing an >>> * emergency shutdown? >>> */ >>> emergency_sync(); >>> kernel_power_off(); >>> } >> >> Yes, it will *IF* userspace fails. the condition that I had tracked >> was before identifying the following fix[1] - Example fail is here[2] >> > > OK. But still, why other users of orderly_poweroff do not > deserve to be fixed, then? > I'd agree as well.. I guess the comment from Robin Holt anticipated something like this will eventually occur. "* I guess this should try to kick off some daemon to sync and * poweroff asap. Or not even bother syncing if we're doing an * emergency shutdown? " Keerthy - would you spin this as a generic fix? >> >> I hope this explains the problem. >> >> [1] >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=00917b5c55aeb01322d5ab51af8c025b82959224 >> [2] http://pastebin.ubuntu.com/14326688/ >> >> [3] >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/am57xx-beagle-x15.dts#n738 >> >> -- >> Regards, >> Nishanth Menon -- Regards, Nishanth Menon