From: Zdenek Kabelac <zkabelac@redhat.com>
To: LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] Could we manually suspend the origin before taking dm-thin snapshots?
Date: Thu, 31 Dec 2015 22:12:47 +0100 [thread overview]
Message-ID: <56859A4F.3020704@redhat.com> (raw)
In-Reply-To: <CAAYit8TFUcWzveNPV3gsknnagWoEZVeKWWfWpKuFfmBauQhS2Q@mail.gmail.com>
Dne 31.12.2015 v 09:40 M.H. Tsai napsal(a):
> Hi All,
>
> I found an issue when taking dm-thin snapshots: LVM doesn't send
> create_snap messages if the origin was already suspended, and LVM
> doesn't report any error.
>
> lvcreate vg1 --type thin --thinpool tp1 --virtualsize 1g
> dmsetup suspend vg1-lv1
> lvcreate vg1/lv1 --snapshot -an
>
Hi
This is completely UNSUPPORTED - you MAY NOT interfere with
LV volumes with 'dmsetup'.
You can use dmsetup only if you know EXACTLY what's going on.
The only recommended usage of dmsetup with lvm2 is - when
lvm2 lacks some error path (e.g. fix mess left after
failing lvm command).
Otherwise there is no point to hijack LVs in the middle
of LV operations - i.e. in cluster world state of LV
(active/suspend) is tightly related to lock state.
> This is due to commit a900d150 moves messaging from resume to suspend,
> then LVM skips the suspend phase in this case. I'm not sure whether it
> is a legal operation for LVM, but if LVM supports this feature, then
> users can control the suspend timing.
plain unsupported state.
You could have been hijacking suspend/resume/remove operation
anytime. In fact you could easily block/freeze whole LV but doing
random suspends of DM devices in your system.
Regards
Zdenek
prev parent reply other threads:[~2015-12-31 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 8:40 [linux-lvm] Could we manually suspend the origin before taking dm-thin snapshots? M.H. Tsai
2015-12-31 21:12 ` Zdenek Kabelac [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56859A4F.3020704@redhat.com \
--to=zkabelac@redhat.com \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.