From: slash.tmp@free.fr (Mason)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] ARM: tango4: Fix build issues
Date: Fri, 1 Jan 2016 12:11:41 +0100 [thread overview]
Message-ID: <56865EED.5020602@free.fr> (raw)
In-Reply-To: <4372399.NmOEe7XGjA@wuerfel>
On 31/12/2015 17:51, Arnd Bergmann wrote:
> On Thursday 31 December 2015 17:31:57 Olof Johansson wrote:
>> On Thu, Dec 31, 2015 at 2:21 PM, Olof Johansson <olof@lixom.net> wrote:
>>> On Fri, Dec 25, 2015 at 10:49:56PM +0100, Mason wrote:
>>>> From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>>>>
>>>> Move SMP setup to platsmp.c
>>>> Specify the CPU type to the assembler, and only for smc.S
>>>>
>>>> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>>>> ---
>>>
>>> Applied, thanks.
>>
>> Actually, I just noticed that the smc.c Makefile part isn't done as it
>> should, so I'll drop this again.
>
> I've applied a different patch now, so we can at least get allmodconfig
> to build again in linux-next:
<confused> Are you saying allmodconfig doesn't build?
The warning you mention is non-fatal.
Is there a setting to make that warning become a fatal error?
(Is -Werror enabled on the linux-next builds?)
> commit 765ff22d54591a24fe81f6a451b953f43e076ced
> Author: Arnd Bergmann <arnd@arndb.de>
> Date: Tue Dec 29 13:43:35 2015 +0100
>
> ARM: tango: pass ARM arch level for smc.S
>
> allmodconfig is broken by the addition of the -mcpu=cortex-a9
> flag for smc.S:
>
> arch/arm/mach-tango/smc.S:1:0: warning: switch -mcpu=cortex-a9 conflicts with -march=armv6k switch
>
> This sets the flag in the same way that all other platforms
> do, to fix the compile error.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/arch/arm/mach-tango/Makefile b/arch/arm/mach-tango/Makefile
> index 0d7e2b5..99422ea 100644
> --- a/arch/arm/mach-tango/Makefile
> +++ b/arch/arm/mach-tango/Makefile
> @@ -1,2 +1,3 @@
> -asflags-y += -mcpu=cortex-a9
> +plus_sec := $(call as-instr,.arch_extension sec,+sec)
> +AFLAGS_smc.o :=-Wa,-march=armv7-a$(plus_sec)
Could you please amend the patch to drop the two extra tabs here?
Regards.
next prev parent reply other threads:[~2016-01-01 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-25 21:49 [PATCH RFC] ARM: tango4: Fix build issues Mason
2015-12-29 20:48 ` Mason
2015-12-30 2:10 ` Joshua Clayton
2015-12-31 13:20 ` Olof Johansson
2015-12-31 13:21 ` Olof Johansson
2015-12-31 16:31 ` Olof Johansson
2015-12-31 16:51 ` Arnd Bergmann
2016-01-01 11:11 ` Mason [this message]
2016-01-01 10:52 ` Mason
2016-01-01 12:03 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56865EED.5020602@free.fr \
--to=slash.tmp@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.