From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Date: Fri, 1 Jan 2016 20:14:24 +0100 Subject: [ath9k-devel] [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() In-Reply-To: <5686C47E.1040906@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <5686C390.5060600@users.sourceforge.net> <5686C47E.1040906@users.sourceforge.net> Message-ID: <5686D010.1060401@rempel-privat.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Am 01.01.2016 um 19:25 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Fri, 1 Jan 2016 19:09:32 +0100 > > Replace an explicit initialisation for one local variable at the beginning > by a conditional assignment. > > Signed-off-by: Markus Elfring > --- > drivers/net/wireless/ath/ath9k/htc_drv_main.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c > index a680a97..30bd59e 100644 > --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c > +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c > @@ -246,7 +246,7 @@ static int ath9k_htc_set_channel(struct ath9k_htc_priv *priv, > struct ieee80211_conf *conf = &common->hw->conf; > bool fastcc; > struct ieee80211_channel *channel = hw->conf.chandef.chan; > - struct ath9k_hw_cal_data *caldata = NULL; > + struct ath9k_hw_cal_data *caldata; > enum htc_phymode mode; > __be16 htc_mode; > u8 cmd_rsp; > @@ -274,10 +274,7 @@ static int ath9k_htc_set_channel(struct ath9k_htc_priv *priv, > priv->ah->curchan->channel, > channel->center_freq, conf_is_ht(conf), conf_is_ht40(conf), > fastcc); > - > - if (!fastcc) > - caldata = &priv->caldata; > - > + caldata = fastcc ? NULL : &priv->caldata; > ret = ath9k_hw_reset(ah, hchan, caldata, fastcc); > if (ret) { > ath_err(common, > Reviewed-by: Oleksij Rempel -- Regards, Oleksij -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 213 bytes Desc: OpenPGP digital signature Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20160101/a7f6d86e/attachment.pgp From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Date: Fri, 01 Jan 2016 19:14:24 +0000 Subject: Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_c Message-Id: <5686D010.1060401@rempel-privat.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="iIDs71WpC9nd6brTonQTiKvAI0rg09UA7" List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5686C390.5060600@users.sourceforge.net> <5686C47E.1040906@users.sourceforge.net> In-Reply-To: <5686C47E.1040906@users.sourceforge.net> To: SF Markus Elfring , ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ath9k-devel@qca.qualcomm.com, Kalle Valo Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iIDs71WpC9nd6brTonQTiKvAI0rg09UA7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 01.01.2016 um 19:25 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Fri, 1 Jan 2016 19:09:32 +0100 >=20 > Replace an explicit initialisation for one local variable at the beginn= ing > by a conditional assignment. >=20 > Signed-off-by: Markus Elfring > --- > drivers/net/wireless/ath/ath9k/htc_drv_main.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/ne= t/wireless/ath/ath9k/htc_drv_main.c > index a680a97..30bd59e 100644 > --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c > +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c > @@ -246,7 +246,7 @@ static int ath9k_htc_set_channel(struct ath9k_htc_p= riv *priv, > struct ieee80211_conf *conf =3D &common->hw->conf; > bool fastcc; > struct ieee80211_channel *channel =3D hw->conf.chandef.chan; > - struct ath9k_hw_cal_data *caldata =3D NULL; > + struct ath9k_hw_cal_data *caldata; > enum htc_phymode mode; > __be16 htc_mode; > u8 cmd_rsp; > @@ -274,10 +274,7 @@ static int ath9k_htc_set_channel(struct ath9k_htc_= priv *priv, > priv->ah->curchan->channel, > channel->center_freq, conf_is_ht(conf), conf_is_ht40(conf), > fastcc); > - > - if (!fastcc) > - caldata =3D &priv->caldata; > - > + caldata =3D fastcc ? NULL : &priv->caldata; > ret =3D ath9k_hw_reset(ah, hchan, caldata, fastcc); > if (ret) { > ath_err(common, >=20 Reviewed-by: Oleksij Rempel --=20 Regards, Oleksij --iIDs71WpC9nd6brTonQTiKvAI0rg09UA7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAlaG0BUACgkQHwImuRkmbWmbIAD/atiZa0Xy3ThlaQHLJVSFBLkS ypnkjeykyF5QClTNPRsA/R2K1RddEZFk+dMfjZdq5iuOaz6oUaz5qvPS2G55rsE2 =KzYR -----END PGP SIGNATURE----- --iIDs71WpC9nd6brTonQTiKvAI0rg09UA7-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.gmx.net ([212.227.17.22]:55637 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752290AbcAATO4 (ORCPT ); Fri, 1 Jan 2016 14:14:56 -0500 Subject: Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() To: SF Markus Elfring , ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ath9k-devel@qca.qualcomm.com, Kalle Valo References: <566ABCD9.1060404@users.sourceforge.net> <5686C390.5060600@users.sourceforge.net> <5686C47E.1040906@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Oleksij Rempel Message-ID: <5686D010.1060401@rempel-privat.de> (sfid-20160101_201549_304538_A7E63D74) Date: Fri, 1 Jan 2016 20:14:24 +0100 MIME-Version: 1.0 In-Reply-To: <5686C47E.1040906@users.sourceforge.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iIDs71WpC9nd6brTonQTiKvAI0rg09UA7" Sender: linux-wireless-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iIDs71WpC9nd6brTonQTiKvAI0rg09UA7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 01.01.2016 um 19:25 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Fri, 1 Jan 2016 19:09:32 +0100 >=20 > Replace an explicit initialisation for one local variable at the beginn= ing > by a conditional assignment. >=20 > Signed-off-by: Markus Elfring > --- > drivers/net/wireless/ath/ath9k/htc_drv_main.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/ne= t/wireless/ath/ath9k/htc_drv_main.c > index a680a97..30bd59e 100644 > --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c > +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c > @@ -246,7 +246,7 @@ static int ath9k_htc_set_channel(struct ath9k_htc_p= riv *priv, > struct ieee80211_conf *conf =3D &common->hw->conf; > bool fastcc; > struct ieee80211_channel *channel =3D hw->conf.chandef.chan; > - struct ath9k_hw_cal_data *caldata =3D NULL; > + struct ath9k_hw_cal_data *caldata; > enum htc_phymode mode; > __be16 htc_mode; > u8 cmd_rsp; > @@ -274,10 +274,7 @@ static int ath9k_htc_set_channel(struct ath9k_htc_= priv *priv, > priv->ah->curchan->channel, > channel->center_freq, conf_is_ht(conf), conf_is_ht40(conf), > fastcc); > - > - if (!fastcc) > - caldata =3D &priv->caldata; > - > + caldata =3D fastcc ? NULL : &priv->caldata; > ret =3D ath9k_hw_reset(ah, hchan, caldata, fastcc); > if (ret) { > ath_err(common, >=20 Reviewed-by: Oleksij Rempel --=20 Regards, Oleksij --iIDs71WpC9nd6brTonQTiKvAI0rg09UA7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAlaG0BUACgkQHwImuRkmbWmbIAD/atiZa0Xy3ThlaQHLJVSFBLkS ypnkjeykyF5QClTNPRsA/R2K1RddEZFk+dMfjZdq5iuOaz6oUaz5qvPS2G55rsE2 =KzYR -----END PGP SIGNATURE----- --iIDs71WpC9nd6brTonQTiKvAI0rg09UA7-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752355AbcAATPQ (ORCPT ); Fri, 1 Jan 2016 14:15:16 -0500 Received: from mout.gmx.net ([212.227.17.22]:55637 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752290AbcAATO4 (ORCPT ); Fri, 1 Jan 2016 14:14:56 -0500 Subject: Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() To: SF Markus Elfring , ath9k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ath9k-devel@qca.qualcomm.com, Kalle Valo References: <566ABCD9.1060404@users.sourceforge.net> <5686C390.5060600@users.sourceforge.net> <5686C47E.1040906@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Oleksij Rempel Message-ID: <5686D010.1060401@rempel-privat.de> Date: Fri, 1 Jan 2016 20:14:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5686C47E.1040906@users.sourceforge.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iIDs71WpC9nd6brTonQTiKvAI0rg09UA7" X-Provags-ID: V03:K0:eXL4Vw8A3RvYITzik5yFXxGcfgg47d6J5EWw83HTRdeKUQlDRhI LlKTYuITOFeb8vYDw8tdy+WhYmfIAzm5GhVYMxzGHAXrk1KCSd5fYbtzrHrzlrxS8CMHHVN PehPfm519YEaqTGHZi3eJUEwOu1viK+qZ31VDn/bOFRpzd7N2vtllw4KE0AN7JVeijQDdmI OxEZ3zaQYnlYpZQLc4GFg== X-UI-Out-Filterresults: notjunk:1;V01:K0:lizfbLgO978=:7JAQW4hIDUyeaQx1G7r+PW jbt14vH2xWrVQp82+OX0tdV3LWEzWbQWxhsUQLXXFbsgTod+MsVbg5frWa3Wpwjw4FIJbKBIK UKdli4QCa+01JWq157GjUfHPuuz9wKFU7dpRZlMRDTvfqYPjzG1e9AHiBf1KWx1uMk2Ci0HFx 127l1ipj7ERYzq120YMdAwqYKqG9GuhFK403ozpMaasyAtni249b+EIFRpaQqs8oDWuoIBM4v /laEJ5G6zdJb7vjkL+CjFAvj5mhYnPcxFj9SUK/VBY6P9R5nq5zn0fWqjIy43RgA60ycYk5gr T7Gxd3C3rMxK4ayD01TyXKxdt/970l+JjdIz5vYK9x2k13PGe7DMrrbNRgBn5KUSJGmCmAIuO KHteR2uO9YAsWqBtiW2QGQF4lEOwDGs2wkyakxPFde1bSToc9z2JNdVYH+NxVyvzmAk73yR05 OZhSGO8VWDcKhrETKOyjK/TQOEeSngOaQWQxZgtixoTCCjBvsNBAjhYnBHuZafu5yp01oDxoR Ayn0QTzDl61fQD1y+yOzFGZGideAzzrzCoEQU0tL8YHKrwKliYrAVQrNtjIn5g/snwz98mmwa 3mlD+4iBBGvkJsis1Hnsp8NiaL6OdYIVJsdP9+d1zno+bePfzqkyFxAk/k/4o8KR0qLO1Wdq7 PUc8hJVxfexZRITaX8v7VH/PuWePwDUYgY4zaP1c4InuSNL7thN4vXzFujJDg+QZTiUMylgHu MENIzb0ZYqKbT8ELMQutpr+yRwKjM24OyDM6c6oiNCaRoPBPfY+lu6YTrCk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iIDs71WpC9nd6brTonQTiKvAI0rg09UA7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 01.01.2016 um 19:25 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Fri, 1 Jan 2016 19:09:32 +0100 >=20 > Replace an explicit initialisation for one local variable at the beginn= ing > by a conditional assignment. >=20 > Signed-off-by: Markus Elfring > --- > drivers/net/wireless/ath/ath9k/htc_drv_main.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/ne= t/wireless/ath/ath9k/htc_drv_main.c > index a680a97..30bd59e 100644 > --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c > +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c > @@ -246,7 +246,7 @@ static int ath9k_htc_set_channel(struct ath9k_htc_p= riv *priv, > struct ieee80211_conf *conf =3D &common->hw->conf; > bool fastcc; > struct ieee80211_channel *channel =3D hw->conf.chandef.chan; > - struct ath9k_hw_cal_data *caldata =3D NULL; > + struct ath9k_hw_cal_data *caldata; > enum htc_phymode mode; > __be16 htc_mode; > u8 cmd_rsp; > @@ -274,10 +274,7 @@ static int ath9k_htc_set_channel(struct ath9k_htc_= priv *priv, > priv->ah->curchan->channel, > channel->center_freq, conf_is_ht(conf), conf_is_ht40(conf), > fastcc); > - > - if (!fastcc) > - caldata =3D &priv->caldata; > - > + caldata =3D fastcc ? NULL : &priv->caldata; > ret =3D ath9k_hw_reset(ah, hchan, caldata, fastcc); > if (ret) { > ath_err(common, >=20 Reviewed-by: Oleksij Rempel --=20 Regards, Oleksij --iIDs71WpC9nd6brTonQTiKvAI0rg09UA7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAlaG0BUACgkQHwImuRkmbWmbIAD/atiZa0Xy3ThlaQHLJVSFBLkS ypnkjeykyF5QClTNPRsA/R2K1RddEZFk+dMfjZdq5iuOaz6oUaz5qvPS2G55rsE2 =KzYR -----END PGP SIGNATURE----- --iIDs71WpC9nd6brTonQTiKvAI0rg09UA7--