From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Date: Fri, 1 Jan 2016 20:14:46 +0100 Subject: [ath9k-devel] [PATCH 1/2] net-ath9k_htc: Delete an unnecessary variable initialisation in ath9k_hif_usb_rx_stream() In-Reply-To: <5686C42A.5000405@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <5686C390.5060600@users.sourceforge.net> <5686C42A.5000405@users.sourceforge.net> Message-ID: <5686D026.6000706@rempel-privat.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Am 01.01.2016 um 19:23 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Fri, 1 Jan 2016 19:00:53 +0100 > > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. > > Signed-off-by: Markus Elfring > --- > drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c > index 165dd20..51bd61b 100644 > --- a/drivers/net/wireless/ath/ath9k/hif_usb.c > +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c > @@ -525,7 +525,7 @@ static void ath9k_hif_usb_rx_stream(struct hif_device_usb *hif_dev, > struct sk_buff *skb) > { > struct sk_buff *nskb, *skb_pool[MAX_PKT_NUM_IN_TRANSFER]; > - int index = 0, i = 0, len = skb->len; > + int index = 0, i, len = skb->len; > int rx_remain_len, rx_pkt_len; > u16 pool_index = 0; > u8 *ptr; > Reviewed-by: Oleksij Rempel -- Regards, Oleksij -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 213 bytes Desc: OpenPGP digital signature Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20160101/9f7764b8/attachment.pgp From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Date: Fri, 01 Jan 2016 19:14:46 +0000 Subject: Re: [PATCH 1/2] net-ath9k_htc: Delete an unnecessary variable initialisation in ath9k_hif_usb_rx_str Message-Id: <5686D026.6000706@rempel-privat.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="8WhpjSiebErDkk2wTiJrdvjCVeaF7cdQR" List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5686C390.5060600@users.sourceforge.net> <5686C42A.5000405@users.sourceforge.net> In-Reply-To: <5686C42A.5000405@users.sourceforge.net> To: SF Markus Elfring , ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ath9k-devel@qca.qualcomm.com, Kalle Valo Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8WhpjSiebErDkk2wTiJrdvjCVeaF7cdQR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 01.01.2016 um 19:23 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Fri, 1 Jan 2016 19:00:53 +0100 >=20 > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. >=20 > Signed-off-by: Markus Elfring > --- > drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wir= eless/ath/ath9k/hif_usb.c > index 165dd20..51bd61b 100644 > --- a/drivers/net/wireless/ath/ath9k/hif_usb.c > +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c > @@ -525,7 +525,7 @@ static void ath9k_hif_usb_rx_stream(struct hif_devi= ce_usb *hif_dev, > struct sk_buff *skb) > { > struct sk_buff *nskb, *skb_pool[MAX_PKT_NUM_IN_TRANSFER]; > - int index =3D 0, i =3D 0, len =3D skb->len; > + int index =3D 0, i, len =3D skb->len; > int rx_remain_len, rx_pkt_len; > u16 pool_index =3D 0; > u8 *ptr; >=20 Reviewed-by: Oleksij Rempel --=20 Regards, Oleksij --8WhpjSiebErDkk2wTiJrdvjCVeaF7cdQR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAlaG0CYACgkQHwImuRkmbWmDhAD+KNPibYR3y8scvydLtCLRK6Im gug4CSunNSk9VLB7NmsA/RdOCOMFBzf9KhnRFhdFDyP7RxRTyCDmKKiyjXmhgigV =FDRM -----END PGP SIGNATURE----- --8WhpjSiebErDkk2wTiJrdvjCVeaF7cdQR-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.gmx.net ([212.227.17.22]:61399 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752293AbcAATPD (ORCPT ); Fri, 1 Jan 2016 14:15:03 -0500 Subject: Re: [PATCH 1/2] net-ath9k_htc: Delete an unnecessary variable initialisation in ath9k_hif_usb_rx_stream() To: SF Markus Elfring , ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ath9k-devel@qca.qualcomm.com, Kalle Valo References: <566ABCD9.1060404@users.sourceforge.net> <5686C390.5060600@users.sourceforge.net> <5686C42A.5000405@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Oleksij Rempel Message-ID: <5686D026.6000706@rempel-privat.de> (sfid-20160101_201540_261300_39EFFE71) Date: Fri, 1 Jan 2016 20:14:46 +0100 MIME-Version: 1.0 In-Reply-To: <5686C42A.5000405@users.sourceforge.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8WhpjSiebErDkk2wTiJrdvjCVeaF7cdQR" Sender: linux-wireless-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8WhpjSiebErDkk2wTiJrdvjCVeaF7cdQR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 01.01.2016 um 19:23 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Fri, 1 Jan 2016 19:00:53 +0100 >=20 > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. >=20 > Signed-off-by: Markus Elfring > --- > drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wir= eless/ath/ath9k/hif_usb.c > index 165dd20..51bd61b 100644 > --- a/drivers/net/wireless/ath/ath9k/hif_usb.c > +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c > @@ -525,7 +525,7 @@ static void ath9k_hif_usb_rx_stream(struct hif_devi= ce_usb *hif_dev, > struct sk_buff *skb) > { > struct sk_buff *nskb, *skb_pool[MAX_PKT_NUM_IN_TRANSFER]; > - int index =3D 0, i =3D 0, len =3D skb->len; > + int index =3D 0, i, len =3D skb->len; > int rx_remain_len, rx_pkt_len; > u16 pool_index =3D 0; > u8 *ptr; >=20 Reviewed-by: Oleksij Rempel --=20 Regards, Oleksij --8WhpjSiebErDkk2wTiJrdvjCVeaF7cdQR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAlaG0CYACgkQHwImuRkmbWmDhAD+KNPibYR3y8scvydLtCLRK6Im gug4CSunNSk9VLB7NmsA/RdOCOMFBzf9KhnRFhdFDyP7RxRTyCDmKKiyjXmhgigV =FDRM -----END PGP SIGNATURE----- --8WhpjSiebErDkk2wTiJrdvjCVeaF7cdQR-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752432AbcAATPV (ORCPT ); Fri, 1 Jan 2016 14:15:21 -0500 Received: from mout.gmx.net ([212.227.17.22]:61399 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752293AbcAATPD (ORCPT ); Fri, 1 Jan 2016 14:15:03 -0500 Subject: Re: [PATCH 1/2] net-ath9k_htc: Delete an unnecessary variable initialisation in ath9k_hif_usb_rx_stream() To: SF Markus Elfring , ath9k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ath9k-devel@qca.qualcomm.com, Kalle Valo References: <566ABCD9.1060404@users.sourceforge.net> <5686C390.5060600@users.sourceforge.net> <5686C42A.5000405@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Oleksij Rempel Message-ID: <5686D026.6000706@rempel-privat.de> Date: Fri, 1 Jan 2016 20:14:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5686C42A.5000405@users.sourceforge.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8WhpjSiebErDkk2wTiJrdvjCVeaF7cdQR" X-Provags-ID: V03:K0:PqAInq21/MwBJ1oYGOClC+1K2DpPH12lHQbGJe4f+Gsy67oBb38 L1TJjEKlBaVCi0uiKF4BeidTVayjpPZTqhoHwYMRqT37/wwPE9wxxA5ZVr+7QZ9LUm2/39H ms2R5YfLbnmq7XsLu9xoQxg85FM7uH1LogEM3GmsaDPf/ShuRB8VLrW7ec5ZVp/R4T3R9Fa 35JFFEYlqMnC005ZFhZSA== X-UI-Out-Filterresults: notjunk:1;V01:K0:NyZ4shWFaSA=:z/McYgGu64a7rpoxF1IsqL Za6/GAvHxlscWB5Rm/OClqNgq2QBBlB5wenngXmdw0Db3mP8XOF1NmW7yWldEbHdbHLqyGitv XzFAyhfQAB1+FMGj3s8vjWGUxMN4E4XDgZAbE5EBSlJBr9KA+wkEZHvI8O31dkawq1N9CGElU Or6xU05qzQcn8+mPXUPiGE4rm3yVQfKRduciU0C1RzB3ZwQ0VKiWj0TtjRoCuV/y9Q69PgpfH 5lj5/Exevppv9nUszrfYqsnWVUbzIgKjv8IatttbsgmnOS8XllBhV7/6Bn7C5YOh7LEZBPeIa MW21RUMMk3bxd1/4qyTFJm1XAYZMtFc1Gt/KrUKwq2/UfAlhrPbsTo8pxecOz4vPdDRTK0gyt XEI45qbug5tNnYTXzOWutfFQl+X3ANqwgwl00+XmaSpDM5XlwmsUSCIRO5KRqv/x1WXTrgz85 5MQB6vlJUL0clULYhO5Wh39EUjUF4lrRmQgxugSVOAatBENzEl8atGq8XL6PKtS2EQQgvYyNk Kql+pPnvtKV+p0YXdfyUNhh9C6Evssf7dXkP6Jr7oPWHEjP0pKoynSeZPNoSeczPQh6eqzjk5 kqVmedoMEVtN2GrF5Mk3IbBf2NSqP9NkhErj1f4UWqTZB9vUOjbNZGwNWu/i37t4bcMw6+FH8 IcJKsNpmKsfnH4NC12wsB4QpXUII52fDSR8I970rBsELyt3HufDmHbcwdE+c3Q8kPSJShQMNU BlF69+8efkp447HLErlVu13GK9JBztXPJJgNWA4Gh/m/IkuZZqAneE1PQn4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8WhpjSiebErDkk2wTiJrdvjCVeaF7cdQR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 01.01.2016 um 19:23 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Fri, 1 Jan 2016 19:00:53 +0100 >=20 > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. >=20 > Signed-off-by: Markus Elfring > --- > drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wir= eless/ath/ath9k/hif_usb.c > index 165dd20..51bd61b 100644 > --- a/drivers/net/wireless/ath/ath9k/hif_usb.c > +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c > @@ -525,7 +525,7 @@ static void ath9k_hif_usb_rx_stream(struct hif_devi= ce_usb *hif_dev, > struct sk_buff *skb) > { > struct sk_buff *nskb, *skb_pool[MAX_PKT_NUM_IN_TRANSFER]; > - int index =3D 0, i =3D 0, len =3D skb->len; > + int index =3D 0, i, len =3D skb->len; > int rx_remain_len, rx_pkt_len; > u16 pool_index =3D 0; > u8 *ptr; >=20 Reviewed-by: Oleksij Rempel --=20 Regards, Oleksij --8WhpjSiebErDkk2wTiJrdvjCVeaF7cdQR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAlaG0CYACgkQHwImuRkmbWmDhAD+KNPibYR3y8scvydLtCLRK6Im gug4CSunNSk9VLB7NmsA/RdOCOMFBzf9KhnRFhdFDyP7RxRTyCDmKKiyjXmhgigV =FDRM -----END PGP SIGNATURE----- --8WhpjSiebErDkk2wTiJrdvjCVeaF7cdQR--