From: Paolo Bonzini <pbonzini@redhat.com>
To: Programmingkid <programmingkidx@gmail.com>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>,
jasowang@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Make rtl8139 network interface card compatible with Mac OS 10.4
Date: Fri, 1 Jan 2016 21:32:30 +0100 [thread overview]
Message-ID: <5686E25E.7020204@redhat.com> (raw)
In-Reply-To: <BEDD3D6D-6ED9-4B23-AFAE-8ADB548D1ADE@gmail.com>
On 29/12/2015 18:59, Programmingkid wrote:
> @@ -699,6 +699,7 @@ static inline int pci_dma_rw(PCIDevice *dev, dma_addr_t addr,
> static inline int pci_dma_read(PCIDevice *dev, dma_addr_t addr,
> void *buf, dma_addr_t len)
> {
> + memory_region_set_enabled(&dev->bus_master_enable_region, true);
> return pci_dma_rw(dev, addr, buf, len, DMA_DIRECTION_TO_DEVICE);
> }
In other words, the driver is buggy and presumably would have never
worked on real hardware?
Paolo
next prev parent reply other threads:[~2016-01-01 20:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 17:59 [Qemu-devel] [PATCH] Make rtl8139 network interface card compatible with Mac OS 10.4 Programmingkid
2015-12-29 21:04 ` Mark Cave-Ayland
2015-12-30 0:05 ` Programmingkid
2015-12-30 0:35 ` Programmingkid
2015-12-30 14:03 ` Mark Cave-Ayland
2015-12-30 16:47 ` Programmingkid
2015-12-30 16:58 ` Mark Cave-Ayland
2015-12-30 17:50 ` Programmingkid
2015-12-31 13:23 ` Mark Cave-Ayland
2015-12-31 18:26 ` Programmingkid
2015-12-31 18:56 ` Mark Cave-Ayland
2015-12-31 19:47 ` Programmingkid
2016-01-02 4:00 ` Programmingkid
2016-01-02 9:39 ` Mark Cave-Ayland
2016-01-02 17:08 ` Programmingkid
2016-01-02 20:46 ` Mark Cave-Ayland
2016-01-01 21:36 ` Paolo Bonzini
2016-01-01 21:49 ` Programmingkid
2016-01-01 20:32 ` Paolo Bonzini [this message]
2016-01-01 20:42 ` Programmingkid
2016-01-01 22:36 ` Paolo Bonzini
2016-01-01 22:42 ` Programmingkid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5686E25E.7020204@redhat.com \
--to=pbonzini@redhat.com \
--cc=jasowang@redhat.com \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.