From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 03 Jan 2016 08:57:12 +0000 Subject: [PATCH 8/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_set_timer() Message-Id: <5688E268.9090600@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> In-Reply-To: <5688DF2D.6090204@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Sun, 3 Jan 2016 09:19:32 +0100 Pass a value directly in a call of the function "regmap_update_bits" instead of an extra initialisation for one local variable at the beginning. Signed-off-by: Markus Elfring --- drivers/rtc/rtc-ab-b5ze-s3.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c index 88f1d0b..fed52d0 100644 --- a/drivers/rtc/rtc-ab-b5ze-s3.c +++ b/drivers/rtc/rtc-ab-b5ze-s3.c @@ -561,7 +561,6 @@ static int _abb5zes3_rtc_set_timer(struct device *dev, struct rtc_wkalrm *alarm, { struct abb5zes3_rtc_data *data = dev_get_drvdata(dev); u8 regs[ABB5ZES3_TIMA_SEC_LEN]; - u8 mask = ABB5ZES3_REG_TIM_CLK_TAC0 | ABB5ZES3_REG_TIM_CLK_TAC1; int ret; /* Program given number of seconds to Timer A registers */ @@ -575,7 +574,9 @@ static int _abb5zes3_rtc_set_timer(struct device *dev, struct rtc_wkalrm *alarm, /* Configure Timer A as a watchdog timer */ ret = regmap_update_bits(data->regmap, ABB5ZES3_REG_TIM_CLK, - mask, ABB5ZES3_REG_TIM_CLK_TAC1); + ABB5ZES3_REG_TIM_CLK_TAC0 + | ABB5ZES3_REG_TIM_CLK_TAC1, + ABB5ZES3_REG_TIM_CLK_TAC1); if (ret) dev_err(dev, "%s: failed to update timer\n", __func__); -- 2.6.3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.web.de (mout.web.de. [212.227.15.3]) by gmr-mx.google.com with ESMTPS id 202si2322120wmf.2.2016.01.03.00.57.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jan 2016 00:57:15 -0800 (PST) Subject: [rtc-linux] [PATCH 8/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_set_timer() To: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5688E268.9090600@users.sourceforge.net> Date: Sun, 3 Jan 2016 09:57:12 +0100 MIME-Version: 1.0 In-Reply-To: <5688DF2D.6090204@users.sourceforge.net> Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , From: Markus Elfring Date: Sun, 3 Jan 2016 09:19:32 +0100 Pass a value directly in a call of the function "regmap_update_bits" instead of an extra initialisation for one local variable at the beginning. Signed-off-by: Markus Elfring --- drivers/rtc/rtc-ab-b5ze-s3.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c index 88f1d0b..fed52d0 100644 --- a/drivers/rtc/rtc-ab-b5ze-s3.c +++ b/drivers/rtc/rtc-ab-b5ze-s3.c @@ -561,7 +561,6 @@ static int _abb5zes3_rtc_set_timer(struct device *dev, struct rtc_wkalrm *alarm, { struct abb5zes3_rtc_data *data = dev_get_drvdata(dev); u8 regs[ABB5ZES3_TIMA_SEC_LEN]; - u8 mask = ABB5ZES3_REG_TIM_CLK_TAC0 | ABB5ZES3_REG_TIM_CLK_TAC1; int ret; /* Program given number of seconds to Timer A registers */ @@ -575,7 +574,9 @@ static int _abb5zes3_rtc_set_timer(struct device *dev, struct rtc_wkalrm *alarm, /* Configure Timer A as a watchdog timer */ ret = regmap_update_bits(data->regmap, ABB5ZES3_REG_TIM_CLK, - mask, ABB5ZES3_REG_TIM_CLK_TAC1); + ABB5ZES3_REG_TIM_CLK_TAC0 + | ABB5ZES3_REG_TIM_CLK_TAC1, + ABB5ZES3_REG_TIM_CLK_TAC1); if (ret) dev_err(dev, "%s: failed to update timer\n", __func__); -- 2.6.3 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752027AbcACI50 (ORCPT ); Sun, 3 Jan 2016 03:57:26 -0500 Received: from mout.web.de ([212.227.15.3]:52902 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbcACI5X (ORCPT ); Sun, 3 Jan 2016 03:57:23 -0500 Subject: [PATCH 8/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_set_timer() To: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5688E268.9090600@users.sourceforge.net> Date: Sun, 3 Jan 2016 09:57:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5688DF2D.6090204@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:mH3xMJdGW8HEAWlpF3sxP4I5sEQY0s9uC+sjXy5Amnlo0ax8lXY RchL6xUKJQtEcuVp7ZSnu6fSw80en5v7CBOkE5y2gKsqI4rHLfOZSAk6XBjclCga9jOH6A2 qc5GDTOjsEn0z8C3gLnPsmtHg96xP8ZYcpt6aBGWFHuT7TEytoC6aFupJsBkLuT37tWgmEp lgbMCJvyzaV/q9Wp7hedw== X-UI-Out-Filterresults: notjunk:1;V01:K0:apx44jxRU+k=:+9ql59eXEhrUd1lAX40+AB kzPzI+GbDxyF45/q5cEATBCcPMfiL5NPX8QX7JUk0m9DS6yySX7pK1w8WVjxC2snA7gv19hEK dj9owfbfUpYcWUGX6ZNwekaRSURgs0AGqhY6IAmKjD3dE4dqO623D9aRGeVLof6cgLKJY9hZQ +J968wgkc/DmbuJ/70qKbP+lsHlxaF0+hi53g/MW3xRfLZ1jtLNPkXvNWZsd68zTuFuoR5GaY AKgAM9O8kVPHcscNRMOmxCf66GdN1dcClv3thCcc5VHAd/dN/M/i7t1IXS6vWatKvtzBC79+y pSNg0CuHH4LM7gpwPrLkXgs/7DdoKdPY5tP0cmnKtZemRZTUdeMAq8Tf4owWzn+h2ym53KCiD BDe/55uixgbPmK7a5KZqepjiYhYkMeSa15bGDQHWDIGfxtNks2SlCv4LfNJ3jYMYhOunXaOSb 93e83YV0OxrbphJdQte4777cxPtOHGBVIzRx8f36WqnrpyPH8w8cgvMs+HoOT+igotmf0T3oB KqbFruIh0KjVq2aG6cIO4MIp7xapCWNcK52hHtQczYSdsf89pjWFMdxS6fZRtHHXWsy5UK2qB rVn+LcVKu3uEdda40GGUGq2i85BuVtIKa3fO9QUOL+eOaALCts7SYCnyNQ8bKE6WTpBOMflq3 X1eP1/kZW1QIW3fkVOuXXVawSNOXeqBD65GntwG7Efmxqe19OdWoAYaavZXX7mhbRhqV2vg84 7JC7iurfBcMvmKQ/F48QS2g2Td1km1Oa/SkLMO0mOltwJTdR3ww7K6AQHbBGkiUnerkF4vGzQ dvDCuqH Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 3 Jan 2016 09:19:32 +0100 Pass a value directly in a call of the function "regmap_update_bits" instead of an extra initialisation for one local variable at the beginning. Signed-off-by: Markus Elfring --- drivers/rtc/rtc-ab-b5ze-s3.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c index 88f1d0b..fed52d0 100644 --- a/drivers/rtc/rtc-ab-b5ze-s3.c +++ b/drivers/rtc/rtc-ab-b5ze-s3.c @@ -561,7 +561,6 @@ static int _abb5zes3_rtc_set_timer(struct device *dev, struct rtc_wkalrm *alarm, { struct abb5zes3_rtc_data *data = dev_get_drvdata(dev); u8 regs[ABB5ZES3_TIMA_SEC_LEN]; - u8 mask = ABB5ZES3_REG_TIM_CLK_TAC0 | ABB5ZES3_REG_TIM_CLK_TAC1; int ret; /* Program given number of seconds to Timer A registers */ @@ -575,7 +574,9 @@ static int _abb5zes3_rtc_set_timer(struct device *dev, struct rtc_wkalrm *alarm, /* Configure Timer A as a watchdog timer */ ret = regmap_update_bits(data->regmap, ABB5ZES3_REG_TIM_CLK, - mask, ABB5ZES3_REG_TIM_CLK_TAC1); + ABB5ZES3_REG_TIM_CLK_TAC0 + | ABB5ZES3_REG_TIM_CLK_TAC1, + ABB5ZES3_REG_TIM_CLK_TAC1); if (ret) dev_err(dev, "%s: failed to update timer\n", __func__); -- 2.6.3