From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] gpio: mxs: add name_to_gpio() function
Date: Sun, 3 Jan 2016 16:05:57 +0100 [thread overview]
Message-ID: <568938D5.8090701@denx.de> (raw)
In-Reply-To: <1450218477-28372-1-git-send-email-mans@mansr.com>
On 15/12/2015 23:27, Mans Rullgard wrote:
> Override the default name_to_gpio() function with one that
> accepts strings of the form bank:pin. If a colon is present
> in the provided name, it behaves like the default version.
>
> This lets the "gpio" command work with sane names rather than
> requiring the user to enter the bank/pin composite in decimal.
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> drivers/gpio/mxs_gpio.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/gpio/mxs_gpio.c b/drivers/gpio/mxs_gpio.c
> index da0199b..b54a10b 100644
> --- a/drivers/gpio/mxs_gpio.c
> +++ b/drivers/gpio/mxs_gpio.c
> @@ -114,3 +114,18 @@ int gpio_free(unsigned gpio)
> {
> return 0;
> }
> +
> +int name_to_gpio(const char *name)
> +{
> + unsigned bank, pin;
> + char *end;
> +
> + bank = simple_strtoul(name, &end, 10);
> +
> + if (!*end || *end != ':')
> + return bank;
> +
> + pin = simple_strtoul(end + 1, NULL, 10);
> +
> + return (bank << MXS_PAD_BANK_SHIFT) | (pin << MXS_PAD_PIN_SHIFT);
> +}
>
Reviewed-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2016-01-03 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 22:27 [U-Boot] [PATCH] gpio: mxs: add name_to_gpio() function Mans Rullgard
2016-01-03 15:05 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568938D5.8090701@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.