All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <mranostay@gmail.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: proximity: lidar: correct return value
Date: Sun, 3 Jan 2016 17:51:46 +0000	[thread overview]
Message-ID: <56895FB2.5040302@kernel.org> (raw)
In-Reply-To: <1451192190-2624-1-git-send-email-mranostay@gmail.com>

On 27/12/15 04:56, Matt Ranostay wrote:
> lidar_i2c_xfer() function was never a non-positive value on error,
> and this correct that with a -EIO return code.
> 
> Signed-off-by: Matt Ranostay <mranostay@gmail.com>

Hmm. Awkward timing on this one.  I'll create a temporary fix
branch for post the merge window closing and send it on to
Greg when appropriate.

This patch could have done with a fixes tag to avoid me having
to look up when this problem was introduced i.e.
Fixes: 366e65633cf4 ("iio: proximity: lidar: optimize i2c transactions")

> ---
>  drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> index 93e29fb..db35e04 100644
> --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> @@ -87,7 +87,7 @@ static int lidar_i2c_xfer(struct lidar_data *data, u8 reg, u8 *val, int len)
>  
>  	ret = i2c_transfer(client->adapter, msg, 2);
>  
> -	return (ret == 2) ? 0 : ret;
> +	return (ret == 2) ? 0 : -EIO;
>  }
>  
>  static int lidar_smbus_xfer(struct lidar_data *data, u8 reg, u8 *val, int len)
> 


      reply	other threads:[~2016-01-03 17:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-27  4:56 [PATCH] iio: proximity: lidar: correct return value Matt Ranostay
2016-01-03 17:51 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56895FB2.5040302@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=mranostay@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.