From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <mranostay@gmail.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: chemical: vz89x: correct xfer return value
Date: Sun, 3 Jan 2016 17:57:46 +0000 [thread overview]
Message-ID: <5689611A.1000409@kernel.org> (raw)
In-Reply-To: <1451193090-3625-1-git-send-email-mranostay@gmail.com>
On 27/12/15 05:11, Matt Ranostay wrote:
> vz89x_i2c_xfer() function was never returning a non-positive value on
> error, and this patch corrects that with a -EIO return code.
>
> Also the error condition was incorrect since it was against measurement
> size and not the i2c messages send/received count.
>
> Signed-off-by: Matt Ranostay <mranostay@gmail.com>
This doesn't apply to the current tree as we already have
an 'incorrect' fix in place for the value being compared against below.
J
> ---
> drivers/iio/chemical/vz89x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/chemical/vz89x.c b/drivers/iio/chemical/vz89x.c
> index c3367aa..0666919 100644
> --- a/drivers/iio/chemical/vz89x.c
> +++ b/drivers/iio/chemical/vz89x.c
> @@ -120,7 +120,7 @@ static int vz89x_i2c_xfer(struct vz89x_data *data, u8 cmd)
>
> ret = i2c_transfer(client->adapter, msg, 2);
>
> - return (ret == VZ89X_REG_MEASUREMENT_SIZE) ? 0 : ret;
> + return (ret == 2) ? 0 : -EIO;
> }
>
> static int vz89x_smbus_xfer(struct vz89x_data *data, u8 cmd)
>
prev parent reply other threads:[~2016-01-03 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 5:11 [PATCH] iio: chemical: vz89x: correct xfer return value Matt Ranostay
2016-01-03 17:57 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5689611A.1000409@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mranostay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.