From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 04 Jan 2016 00:08:42 +0100 (CET) Received: from bh-25.webhostbox.net ([208.91.199.152]:58557 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27007789AbcACXIkJS0VB (ORCPT ); Mon, 4 Jan 2016 00:08:40 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject; bh=PJ66xs601Z3cmhXEKheOwMf4RmAa+57Sjx3Iz6tXsCw=; b=zPD23m97EjrxUsFE62G87pPkX0 UvTeIpgjBxNE+lO1rfsbmCKsJW6xWYg2vCelsApU57hX1lVEnWFXe9mAS9L9/rFLYJsOEllyUZINJ DpDUJXDELZizNhaFlN/cU3jBjhJiSHg23+Pyk7Mq4na7bRmrKv+HzCICFIhOxsiLjY9I=; Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:52310 helo=server.roeck-us.net) by bh-25.webhostbox.net with esmtpsa (TLSv1:DHE-RSA-AES128-SHA:128) (Exim 4.86) (envelope-from ) id 1aFrla-003zy0-LS; Sun, 03 Jan 2016 23:08:52 +0000 Subject: Re: [PATCH -next] MIPS: VDSO: Fix build error with binutils 2.24 and earlier To: Ralf Baechle References: <1450933471-7357-1-git-send-email-linux@roeck-us.net> Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Qais Yousef , James Hogan From: Guenter Roeck Message-ID: <5689A9ED.5080506@roeck-us.net> Date: Sun, 3 Jan 2016 15:08:29 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450933471-7357-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - linux-mips.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 50834 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: linux@roeck-us.net Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 12/23/2015 09:04 PM, Guenter Roeck wrote: > Commit 2a037f310bab ("MIPS: VDSO: Fix build error") tries to fix a build > error seen with binutils 2.24 and earlier. However, the fix does not work, > and again results in the already known build errors if the kernel is built > with an earlier version of binutils. > > CC arch/mips/vdso/gettimeofday.o > /tmp/ccnOVbHT.s: Assembler messages: > /tmp/ccnOVbHT.s:50: Error: can't resolve `_start' {*UND* section} - `L0 {.text section} > /tmp/ccnOVbHT.s:374: Error: can't resolve `_start' {*UND* section} - `L0 {.text section} > scripts/Makefile.build:258: recipe for target 'arch/mips/vdso/gettimeofday.o' failed > make[2]: *** [arch/mips/vdso/gettimeofday.o] Error 1 > > Fixes: 2a037f310bab ("MIPS: VDSO: Fix build error") The above patch, and thus the build error with binutils 2.24 and earlier introduced by it, has now made it into the mainline kernel. Guenter > Cc: Qais Yousef > Signed-off-by: Guenter Roeck > --- > Tested with binutils 2.25 and 2.22. > > arch/mips/vdso/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile > index 018f8c7b94f2..14568900fc1d 100644 > --- a/arch/mips/vdso/Makefile > +++ b/arch/mips/vdso/Makefile > @@ -26,7 +26,7 @@ aflags-vdso := $(ccflags-vdso) \ > # the comments on that file. > # > ifndef CONFIG_CPU_MIPSR6 > - ifeq ($(call ld-ifversion, -lt, 22500000, y),) > + ifeq ($(call ld-ifversion, -lt, 22500000, y),y) > $(warning MIPS VDSO requires binutils >= 2.25) > obj-vdso-y := $(filter-out gettimeofday.o, $(obj-vdso-y)) > ccflags-vdso += -DDISABLE_MIPS_VDSO >