From: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Geliang Tang <geliangtang-9Onoh4P/yGk@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cgroup: make /proc/cgroups aligned
Date: Mon, 4 Jan 2016 09:16:42 +0800 [thread overview]
Message-ID: <5689C7FA.9000502@huawei.com> (raw)
In-Reply-To: <e814e0db26aa5a3662c1e98dc1410c6b3e9a4c12.1451837184.git.geliangtang-9Onoh4P/yGk@public.gmane.org>
On 2016/1/4 0:08, Geliang Tang wrote:
> This patch makes /proc/cgroups aligned like this:
> $ cat /proc/cgroups
> #subsys_name hierarchy num_cgroups enabled
> cpuset 11 1 1
> cpu 2 1 1
> cpuacct 2 1 1
> blkio 12 1 1
> memory 3 1 1
> devices 4 83 1
> freezer 10 1 1
> perf_event 9 1 1
> hugetlb 7 1 1
> intel_rdt 6 1 1
> pids 8 1 1
> debug 5 1 1
>
> Signed-off-by: Geliang Tang <geliangtang-9Onoh4P/yGk@public.gmane.org>
This change is not acceptable because it may break userspace.
> ---
> kernel/cgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index f1603c1..063b28f 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -5411,7 +5411,7 @@ static int proc_cgroupstats_show(struct seq_file *m, void *v)
> mutex_lock(&cgroup_mutex);
>
> for_each_subsys(ss, i)
> - seq_printf(m, "%s\t%d\t%d\t%d\n",
> + seq_printf(m, "%12s\t%9d\t%11d\t%7d\n",
> ss->legacy_name, ss->root->hierarchy_id,
> atomic_read(&ss->root->nr_cgrps),
> cgroup_ssid_enabled(i));
>
WARNING: multiple messages have this Message-ID (diff)
From: Zefan Li <lizefan@huawei.com>
To: Geliang Tang <geliangtang@163.com>, Tejun Heo <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>
Cc: <cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cgroup: make /proc/cgroups aligned
Date: Mon, 4 Jan 2016 09:16:42 +0800 [thread overview]
Message-ID: <5689C7FA.9000502@huawei.com> (raw)
In-Reply-To: <e814e0db26aa5a3662c1e98dc1410c6b3e9a4c12.1451837184.git.geliangtang@163.com>
On 2016/1/4 0:08, Geliang Tang wrote:
> This patch makes /proc/cgroups aligned like this:
> $ cat /proc/cgroups
> #subsys_name hierarchy num_cgroups enabled
> cpuset 11 1 1
> cpu 2 1 1
> cpuacct 2 1 1
> blkio 12 1 1
> memory 3 1 1
> devices 4 83 1
> freezer 10 1 1
> perf_event 9 1 1
> hugetlb 7 1 1
> intel_rdt 6 1 1
> pids 8 1 1
> debug 5 1 1
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
This change is not acceptable because it may break userspace.
> ---
> kernel/cgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index f1603c1..063b28f 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -5411,7 +5411,7 @@ static int proc_cgroupstats_show(struct seq_file *m, void *v)
> mutex_lock(&cgroup_mutex);
>
> for_each_subsys(ss, i)
> - seq_printf(m, "%s\t%d\t%d\t%d\n",
> + seq_printf(m, "%12s\t%9d\t%11d\t%7d\n",
> ss->legacy_name, ss->root->hierarchy_id,
> atomic_read(&ss->root->nr_cgrps),
> cgroup_ssid_enabled(i));
>
next prev parent reply other threads:[~2016-01-04 1:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 16:08 [PATCH] cgroup: make /proc/cgroups aligned Geliang Tang
2016-01-03 16:08 ` Geliang Tang
[not found] ` <e814e0db26aa5a3662c1e98dc1410c6b3e9a4c12.1451837184.git.geliangtang-9Onoh4P/yGk@public.gmane.org>
2016-01-04 1:16 ` Zefan Li [this message]
2016-01-04 1:16 ` Zefan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5689C7FA.9000502@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=geliangtang-9Onoh4P/yGk@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.