All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cgroup: make /proc/cgroups aligned
@ 2016-01-03 16:08 ` Geliang Tang
  0 siblings, 0 replies; 4+ messages in thread
From: Geliang Tang @ 2016-01-03 16:08 UTC (permalink / raw)
  To: Tejun Heo, Li Zefan, Johannes Weiner
  Cc: Geliang Tang, cgroups-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

This patch makes /proc/cgroups aligned like this:
$ cat /proc/cgroups
#subsys_name    hierarchy       num_cgroups     enabled
      cpuset           11                 1           1
         cpu            2                 1           1
     cpuacct            2                 1           1
       blkio           12                 1           1
      memory            3                 1           1
     devices            4                83           1
     freezer           10                 1           1
  perf_event            9                 1           1
     hugetlb            7                 1           1
   intel_rdt            6                 1           1
        pids            8                 1           1
       debug            5                 1           1

Signed-off-by: Geliang Tang <geliangtang-9Onoh4P/yGk@public.gmane.org>
---
 kernel/cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index f1603c1..063b28f 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -5411,7 +5411,7 @@ static int proc_cgroupstats_show(struct seq_file *m, void *v)
 	mutex_lock(&cgroup_mutex);
 
 	for_each_subsys(ss, i)
-		seq_printf(m, "%s\t%d\t%d\t%d\n",
+		seq_printf(m, "%12s\t%9d\t%11d\t%7d\n",
 			   ss->legacy_name, ss->root->hierarchy_id,
 			   atomic_read(&ss->root->nr_cgrps),
 			   cgroup_ssid_enabled(i));
-- 
2.5.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] cgroup: make /proc/cgroups aligned
@ 2016-01-03 16:08 ` Geliang Tang
  0 siblings, 0 replies; 4+ messages in thread
From: Geliang Tang @ 2016-01-03 16:08 UTC (permalink / raw)
  To: Tejun Heo, Li Zefan, Johannes Weiner; +Cc: Geliang Tang, cgroups, linux-kernel

This patch makes /proc/cgroups aligned like this:
$ cat /proc/cgroups
#subsys_name    hierarchy       num_cgroups     enabled
      cpuset           11                 1           1
         cpu            2                 1           1
     cpuacct            2                 1           1
       blkio           12                 1           1
      memory            3                 1           1
     devices            4                83           1
     freezer           10                 1           1
  perf_event            9                 1           1
     hugetlb            7                 1           1
   intel_rdt            6                 1           1
        pids            8                 1           1
       debug            5                 1           1

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 kernel/cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index f1603c1..063b28f 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -5411,7 +5411,7 @@ static int proc_cgroupstats_show(struct seq_file *m, void *v)
 	mutex_lock(&cgroup_mutex);
 
 	for_each_subsys(ss, i)
-		seq_printf(m, "%s\t%d\t%d\t%d\n",
+		seq_printf(m, "%12s\t%9d\t%11d\t%7d\n",
 			   ss->legacy_name, ss->root->hierarchy_id,
 			   atomic_read(&ss->root->nr_cgrps),
 			   cgroup_ssid_enabled(i));
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] cgroup: make /proc/cgroups aligned
  2016-01-03 16:08 ` Geliang Tang
@ 2016-01-04  1:16     ` Zefan Li
  -1 siblings, 0 replies; 4+ messages in thread
From: Zefan Li @ 2016-01-04  1:16 UTC (permalink / raw)
  To: Geliang Tang, Tejun Heo, Johannes Weiner
  Cc: cgroups-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On 2016/1/4 0:08, Geliang Tang wrote:
> This patch makes /proc/cgroups aligned like this:
> $ cat /proc/cgroups
> #subsys_name    hierarchy       num_cgroups     enabled
>        cpuset           11                 1           1
>           cpu            2                 1           1
>       cpuacct            2                 1           1
>         blkio           12                 1           1
>        memory            3                 1           1
>       devices            4                83           1
>       freezer           10                 1           1
>    perf_event            9                 1           1
>       hugetlb            7                 1           1
>     intel_rdt            6                 1           1
>          pids            8                 1           1
>         debug            5                 1           1
>
> Signed-off-by: Geliang Tang <geliangtang-9Onoh4P/yGk@public.gmane.org>

This change is not acceptable because it may break userspace.

> ---
>   kernel/cgroup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index f1603c1..063b28f 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -5411,7 +5411,7 @@ static int proc_cgroupstats_show(struct seq_file *m, void *v)
>   	mutex_lock(&cgroup_mutex);
>
>   	for_each_subsys(ss, i)
> -		seq_printf(m, "%s\t%d\t%d\t%d\n",
> +		seq_printf(m, "%12s\t%9d\t%11d\t%7d\n",
>   			   ss->legacy_name, ss->root->hierarchy_id,
>   			   atomic_read(&ss->root->nr_cgrps),
>   			   cgroup_ssid_enabled(i));
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] cgroup: make /proc/cgroups aligned
@ 2016-01-04  1:16     ` Zefan Li
  0 siblings, 0 replies; 4+ messages in thread
From: Zefan Li @ 2016-01-04  1:16 UTC (permalink / raw)
  To: Geliang Tang, Tejun Heo, Johannes Weiner; +Cc: cgroups, linux-kernel

On 2016/1/4 0:08, Geliang Tang wrote:
> This patch makes /proc/cgroups aligned like this:
> $ cat /proc/cgroups
> #subsys_name    hierarchy       num_cgroups     enabled
>        cpuset           11                 1           1
>           cpu            2                 1           1
>       cpuacct            2                 1           1
>         blkio           12                 1           1
>        memory            3                 1           1
>       devices            4                83           1
>       freezer           10                 1           1
>    perf_event            9                 1           1
>       hugetlb            7                 1           1
>     intel_rdt            6                 1           1
>          pids            8                 1           1
>         debug            5                 1           1
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>

This change is not acceptable because it may break userspace.

> ---
>   kernel/cgroup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index f1603c1..063b28f 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -5411,7 +5411,7 @@ static int proc_cgroupstats_show(struct seq_file *m, void *v)
>   	mutex_lock(&cgroup_mutex);
>
>   	for_each_subsys(ss, i)
> -		seq_printf(m, "%s\t%d\t%d\t%d\n",
> +		seq_printf(m, "%12s\t%9d\t%11d\t%7d\n",
>   			   ss->legacy_name, ss->root->hierarchy_id,
>   			   atomic_read(&ss->root->nr_cgrps),
>   			   cgroup_ssid_enabled(i));
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-01-04  1:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-03 16:08 [PATCH] cgroup: make /proc/cgroups aligned Geliang Tang
2016-01-03 16:08 ` Geliang Tang
     [not found] ` <e814e0db26aa5a3662c1e98dc1410c6b3e9a4c12.1451837184.git.geliangtang-9Onoh4P/yGk@public.gmane.org>
2016-01-04  1:16   ` Zefan Li
2016-01-04  1:16     ` Zefan Li

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.