From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zefan Li Subject: Re: [PATCH] cgroup: make /proc/cgroups aligned Date: Mon, 4 Jan 2016 09:16:42 +0800 Message-ID: <5689C7FA.9000502@huawei.com> References: Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Geliang Tang , Tejun Heo , Johannes Weiner Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 2016/1/4 0:08, Geliang Tang wrote: > This patch makes /proc/cgroups aligned like this: > $ cat /proc/cgroups > #subsys_name hierarchy num_cgroups enabled > cpuset 11 1 1 > cpu 2 1 1 > cpuacct 2 1 1 > blkio 12 1 1 > memory 3 1 1 > devices 4 83 1 > freezer 10 1 1 > perf_event 9 1 1 > hugetlb 7 1 1 > intel_rdt 6 1 1 > pids 8 1 1 > debug 5 1 1 > > Signed-off-by: Geliang Tang This change is not acceptable because it may break userspace. > --- > kernel/cgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index f1603c1..063b28f 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -5411,7 +5411,7 @@ static int proc_cgroupstats_show(struct seq_file *m, void *v) > mutex_lock(&cgroup_mutex); > > for_each_subsys(ss, i) > - seq_printf(m, "%s\t%d\t%d\t%d\n", > + seq_printf(m, "%12s\t%9d\t%11d\t%7d\n", > ss->legacy_name, ss->root->hierarchy_id, > atomic_read(&ss->root->nr_cgrps), > cgroup_ssid_enabled(i)); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752530AbcADBRc (ORCPT ); Sun, 3 Jan 2016 20:17:32 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:11872 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbcADBRa (ORCPT ); Sun, 3 Jan 2016 20:17:30 -0500 Subject: Re: [PATCH] cgroup: make /proc/cgroups aligned To: Geliang Tang , Tejun Heo , "Johannes Weiner" References: CC: , From: Zefan Li Message-ID: <5689C7FA.9000502@huawei.com> Date: Mon, 4 Jan 2016 09:16:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.236] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090201.5689C809.0025,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 4d7d75b39b28ce4e102fcf7cf7909f89 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/4 0:08, Geliang Tang wrote: > This patch makes /proc/cgroups aligned like this: > $ cat /proc/cgroups > #subsys_name hierarchy num_cgroups enabled > cpuset 11 1 1 > cpu 2 1 1 > cpuacct 2 1 1 > blkio 12 1 1 > memory 3 1 1 > devices 4 83 1 > freezer 10 1 1 > perf_event 9 1 1 > hugetlb 7 1 1 > intel_rdt 6 1 1 > pids 8 1 1 > debug 5 1 1 > > Signed-off-by: Geliang Tang This change is not acceptable because it may break userspace. > --- > kernel/cgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index f1603c1..063b28f 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -5411,7 +5411,7 @@ static int proc_cgroupstats_show(struct seq_file *m, void *v) > mutex_lock(&cgroup_mutex); > > for_each_subsys(ss, i) > - seq_printf(m, "%s\t%d\t%d\t%d\n", > + seq_printf(m, "%12s\t%9d\t%11d\t%7d\n", > ss->legacy_name, ss->root->hierarchy_id, > atomic_read(&ss->root->nr_cgrps), > cgroup_ssid_enabled(i)); >