From: Kang Kai <Kai.Kang@windriver.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] Revert "glib-2.0: build dependency cleanup"
Date: Mon, 4 Jan 2016 10:09:21 +0800 [thread overview]
Message-ID: <5689D451.3090005@windriver.com> (raw)
In-Reply-To: <D6F56C56-75BE-40AD-BDDC-AE6F14263057@gmail.com>
On 2015年12月31日 16:50, Khem Raj wrote:
>> On Dec 29, 2015, at 1:43 AM, kai.kang@windriver.com wrote:
>>
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> This reverts commit fcd7494b347423185c883b2897c4908929843a71.
>>
>> It uses command glib-genmarshal to build glib-2.0 which is from
>> glibc-2.0-native. If the command doesn't exist on host, build fails
> typo 'glib-2.0-native'
Correct it in pull branch on poky-contrib. Thanks.
--Kai
>
>> with error:
>>
>> | /bin/sh: --prefix=test_marshal: command not found
>> | make[4]: *** [testmarshal.c] Error 127
>>
>> So add the dependency back.
> I ran into the regression as well. So this patch is good.
>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>> meta/recipes-core/glib-2.0/glib.inc | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
>> index 86f7e0e..8e4dcd7 100644
>> --- a/meta/recipes-core/glib-2.0/glib.inc
>> +++ b/meta/recipes-core/glib-2.0/glib.inc
>> @@ -17,10 +17,10 @@ SECTION = "libs"
>>
>> BBCLASSEXTEND = "native nativesdk"
>>
>> -DEPENDS = "virtual/libiconv libffi zlib"
>> -DEPENDS_append = " ${@bb.utils.contains('PTEST_ENABLED', '1', ' glib-2.0-native dbus', '', d)}"
>> +DEPENDS = "glib-2.0-native virtual/libiconv libffi zlib"
>> +DEPENDS_append_class-target = "${@bb.utils.contains('DISTRO_FEATURES', 'ptest', ' dbus', '', d)}"
>> DEPENDS_class-native = "pkgconfig-native gettext-native libffi-native zlib-native"
>> -DEPENDS_class-nativesdk = "nativesdk-libtool nativesdk-gettext nativesdk-libffi nativesdk-zlib"
>> +DEPENDS_class-nativesdk = "nativesdk-libtool nativesdk-gettext nativesdk-libffi nativesdk-zlib ${BPN}-native"
>>
>> PACKAGES =+ "${PN}-utils ${PN}-bash-completion ${PN}-codegen"
>>
>> --
>> 2.6.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Regards,
Neil | Kai Kang
next prev parent reply other threads:[~2016-01-04 2:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 9:43 [PATCH 0/1] Add dependency back for glib-2.0 kai.kang
2015-12-29 9:43 ` [PATCH 1/1] Revert "glib-2.0: build dependency cleanup" kai.kang
2015-12-31 8:50 ` Khem Raj
2016-01-04 2:09 ` Kang Kai [this message]
2016-01-04 10:47 ` Burton, Ross
2016-01-06 2:33 ` Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5689D451.3090005@windriver.com \
--to=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.