From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Mon, 4 Jan 2016 08:08:10 +0100 Subject: [U-Boot] [PATCH 08/10] i2c: Correct command return values In-Reply-To: <1451391772-6203-9-git-send-email-sjg@chromium.org> References: <1451391772-6203-1-git-send-email-sjg@chromium.org> <1451391772-6203-9-git-send-email-sjg@chromium.org> Message-ID: <568A1A5A.2080602@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, Am 29.12.2015 um 13:22 schrieb Simon Glass: > We should not return a -ve error code from command functions. Instead, > return CMD_RET_FAILURE. This avoids the "exit not allowed from main input > shell" error messages from the hush shell. > > Signed-off-by: Simon Glass > --- > > common/cmd_i2c.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Thanks! As it is in a patchserie: Acked-by: Heiko Schocher bye, Heiko > > diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c > index 552c875..b3bb644 100644 > --- a/common/cmd_i2c.c > +++ b/common/cmd_i2c.c > @@ -1809,7 +1809,8 @@ static int do_i2c_bus_num(cmd_tbl_t *cmdtp, int flag, int argc, > if (ret) > printf("Failure changing bus number (%d)\n", ret); > } > - return ret; > + > + return ret ? CMD_RET_FAILURE : 0; > } > #endif /* defined(CONFIG_SYS_I2C) */ > > @@ -1852,7 +1853,8 @@ static int do_i2c_bus_speed(cmd_tbl_t * cmdtp, int flag, int argc, char * const > if (ret) > printf("Failure changing bus speed (%d)\n", ret); > } > - return ret; > + > + return ret ? CMD_RET_FAILURE : 0; > } > > /** > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany